Bug #61028 for Dist-Zilla-Plugin-MinimumPerl: Don't scan examples directories

Fri Sep 03 11:04:46 2010 dagolden [...] cpan.org - Ticket created

Subject:

Don't scan examples directories

The plugin scans all files, including examples/. It should scan only lib, inc and t. Even better would be to have lib/ set 'requires', inc/ set 'configure_requires' and t/ set 'test_requires'. But I'd be happy enough if it just scanned those and nothing else. -- David

Mon Dec 06 13:11:57 2010 APOCAL [...] cpan.org - Correspondence added

Hello, Thanks for the notice! Looking into dzil, I realized that I can use the FileFinderUser role and now it only scans modules and executable files. That should be good enough for now, deal? I'm leaving this ticket open as a TODO because I like your idea of having per-phase perl requires, but at the same time it's a bit wacky? How can the toolchain cope with a lib requires of 5.8.0 and test requires of 5.10.0? I assume a blanket version requirement is sufficient to cover the entire dist? Thanks again! -- ~Apocalypse

Mon Dec 06 13:11:58 2010 The RT System itself - Status changed from 'new' to 'open'

Mon Dec 06 16:49:29 2010 dagolden [...] cpan.org - Correspondence added

On Mon Dec 06 13:11:57 2010, APOCAL wrote: Show quoted text

> Thanks for the notice! Looking into dzil, I realized that I can use the > FileFinderUser role and now it only scans modules and executable files. > That should be good enough for now, deal?

That would be great! Thank you. David

Mon Dec 13 20:50:48 2010 APOCAL [...] cpan.org - Correspondence added

Thanks again for the idea and prodding me to fix it :) v1.001 on CPAN fixes this. It doesn't specify per-phase requires, tho. However, I've sent a patch to RJBS adding a new IncModules finder to dzil. He showed interest in merging it, but found no "real" reason to use the finder, ha! When he updates dzil, I'll update MinimumPerl to use it and specify per-phase requires more accurately. However, I wonder how the CPAN-Meta-Converter works when converting to 1.4? Which phase's perl will it pick as the prereq? Hope you can help me answer that :) -- ~Apocalypse

Mon Dec 13 21:29:28 2010 dagolden [...] cpan.org - Correspondence added

Subject:	Re: [rt.cpan.org #61028] Don't scan examples directories
Date:	Mon, 13 Dec 2010 21:28:59 -0500
To:	bug-Dist-Zilla-Plugin-MinimumPerl [...] rt.cpan.org
From:	David Golden <dagolden [...] cpan.org>

On Mon, Dec 13, 2010 at 8:50 PM, Apocalypse via RT <bug-Dist-Zilla-Plugin-MinimumPerl@rt.cpan.org> wrote: Show quoted text

> However, I wonder how the CPAN-Meta-Converter works when converting to > 1.4? Which phase's perl will it pick as the prereq? Hope you can help me > answer that :)

I'm pretty sure both test/requires and build/requires map to build_requires in the 1.4 spec. Any recommends/suggests are probably dropped on the floor. -- David

Mon Dec 13 22:00:19 2010 perl [...] 0ne.us - Correspondence added

Subject:	Re: [rt.cpan.org #61028] Don't scan examples directories
Date:	Mon, 13 Dec 2010 20:00:10 -0700
To:	bug-Dist-Zilla-Plugin-MinimumPerl [...] rt.cpan.org
From:	"perl [...] 0ne.us" <perl [...] 0ne.us>

David Golden via RT wrote: Show quoted text

> Queue: Dist-Zilla-Plugin-MinimumPerl > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=61028 > > > On Mon, Dec 13, 2010 at 8:50 PM, Apocalypse via RT > <bug-Dist-Zilla-Plugin-MinimumPerl@rt.cpan.org> wrote: >

>> However, I wonder how the CPAN-Meta-Converter works when converting to >> 1.4? Which phase's perl will it pick as the prereq? Hope you can help me >> answer that :) >>

> > I'm pretty sure both test/requires and build/requires map to > build_requires in the 1.4 spec. Any recommends/suggests are probably > dropped on the floor. > > -- David > >

Hmm, what if test/requires a perl = 5.8.0 and build/requires a perl = 5.10.0 Which one will end up in the 1.4 spec? Does it do any smart handling like pick the highest required ver? All this pondering might be pointless, because I suspect I can't control that behavior in my plugin ;) Thanks!

Mon Dec 13 23:30:57 2010 dagolden [...] cpan.org - Correspondence added

Subject:	Re: [rt.cpan.org #61028] Don't scan examples directories
Date:	Mon, 13 Dec 2010 23:30:22 -0500
To:	bug-Dist-Zilla-Plugin-MinimumPerl [...] rt.cpan.org
From:	David Golden <dagolden [...] cpan.org>

On Mon, Dec 13, 2010 at 10:00 PM, Apocalypse via RT <bug-Dist-Zilla-Plugin-MinimumPerl@rt.cpan.org> wrote: Show quoted text

> Hmm, what if test/requires a perl = 5.8.0 and build/requires a perl = 5.10.0 > > Which one will end up in the 1.4 spec? Does it do any smart handling > like pick the highest required ver?

It might just merge them. build_requires => "5.8.0, 5.10.0" Both have to be satisfied. It's a quirk in the spec that it allows it, but it works. I don't know for sure that's how I implemented it, though. David

Mon Oct 27 22:20:15 2014 APOCAL [...] cpan.org - Correspondence added

Hello, This has been a long time coming but I'm going to release v1.004 with this change :) Thanks again for your patience! On Mon Dec 13 23:30:57 2010, DAGOLDEN wrote: Show quoted text

> On Mon, Dec 13, 2010 at 10:00 PM, Apocalypse via RT > <bug-Dist-Zilla-Plugin-MinimumPerl@rt.cpan.org> wrote:

> > Hmm, what if test/requires a perl = 5.8.0 and build/requires a perl = > > 5.10.0 > > > > Which one will end up in the 1.4 spec? Does it do any smart handling > > like pick the highest required ver?

> > It might just merge them. build_requires => "5.8.0, 5.10.0" > > Both have to be satisfied. It's a quirk in the spec that it allows it, > but it works. > > I don't know for sure that's how I implemented it, though. > > David

-- ~Apocalypse

Mon Oct 27 22:20:16 2014 APOCAL [...] cpan.org - Status changed from 'open' to 'resolved'