Skip Menu |

This queue is for tickets about the Module-Info CPAN distribution.

Report information
The Basics
Id: 61018
Status: resolved
Priority: 0/
Queue: Module-Info

People
Owner: Nobody in particular
Requestors: jonasbn [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 0.31
Fixed in: (no value)



Subject: Tests break on OSX 10.6.4 System Perl
Hello, I observed some issues with the test suite on OSX/Darwin 10.6.4 with the system perl. The test has to do with the expectations toward the contents of: $Config{installarchlib} $Config{installprivlib} And the installation path and modules installed as core. The test in question is assuming it can be resolved using the above, particularly when looking for a core module, namely: Text::Soundex On OSX using System perl Text::Soundex is located at: /System/Library/Perl/5.10.0/darwin-thread-multi-2level/Text/Soundex.pm If you however check the values of the paths inspected in the test and in the is_core method, the following it looks in: /Library/Perl/Updates/5.10.0/darwin-thread-multi-2level ($Config{installarchlib}) /Library/Perl/Updates/5.10.0 ($Config{installprivlib}) I have included two patches for the test and the is_core method taking, adding to the list of paths, so these are extended with: archlib and privlib. I am unsure at to whether this is the correct approach, since I do not have an overview of the use of these paths and how they should be interpreted exactly, but this makes the test suite pass on OSX/Darwin. Take care, jonasbn
Subject: Module-Info.t.patch
--- t/Module-Info.t 2007-05-28 21:26:35.000000000 +0200 +++ t/Module-Info.t.mine 2010-09-03 10:31:34.000000000 +0200 @@ -116,7 +116,8 @@ # Grab the core version of Text::Soundex and hope it hasn't been # deleted. @core_inc = map { File::Spec->canonpath($_) } - ($Config{installarchlib}, $Config{installprivlib}); + ($Config{installarchlib}, $Config{installprivlib}, + $Config{archlib}, $Config{privlib}); $mod_info = Module::Info->new_from_module('Text::Soundex', @core_inc); is( $mod_info->name, 'Text::Soundex', ' name()' );
Subject: Info.pm.patch
--- lib/Module/Info.pm 2007-05-28 21:27:24.000000000 +0200 +++ lib/Module/Info.pm.mine 2010-09-03 10:41:36.000000000 +0200 @@ -307,7 +307,9 @@ return scalar grep $self->{dir} eq File::Spec->canonpath($_), ($Config{installarchlib}, - $Config{installprivlib}); + $Config{installprivlib} + $Config{archlib}, + $Config{privlib}); } =back
Argh, one of the patches was bad. Attaching a new one. jonasbn
Subject: Info.pm.patch
--- lib/Module/Info.pm 2007-05-28 21:27:24.000000000 +0200 +++ lib/Module/Info.pm.mine 2010-09-03 10:41:36.000000000 +0200 @@ -307,7 +307,9 @@ return scalar grep $self->{dir} eq File::Spec->canonpath($_), ($Config{installarchlib}, - $Config{installprivlib}); + $Config{installprivlib}, + $Config{archlib}, + $Config{privlib}); } =back
Manually pilfered in the patch file, not sure this was a good idea. Regenerated the patch and tested it. So here you go (again) jonasbn
Subject: Info.pm.patch
--- lib/Module/Info.pm 2007-05-28 21:27:24.000000000 +0200 +++ lib/Module/Info.pm.mine 2010-09-03 11:05:09.000000000 +0200 @@ -307,7 +307,9 @@ return scalar grep $self->{dir} eq File::Spec->canonpath($_), ($Config{installarchlib}, - $Config{installprivlib}); + $Config{installprivlib}, + $Config{archlib}, + $Config{privlib}); } =back
Il Ven 03 Set 2010 04:54:18, JONASBN ha scritto: Hi, Show quoted text
> I observed some issues with the test suite on OSX/Darwin 10.6.4 with the > system perl. > > The test has to do with the expectations toward the contents of: > > $Config{installarchlib} > $Config{installprivlib}
<snip> Show quoted text
> I have included two patches for the test and the is_core method taking, > adding to the list of paths, so these > are extended with: archlib and privlib. > > I am unsure at to whether this is the correct approach, since I do not > have an overview of the use of these paths and how they should be > interpreted exactly, but this makes the test suite pass on OSX/Darwin.
According to Config.pm documentation, M::I should probably use archlib and privlib only (but I am not 100% sure); I think using both the priv- and non-priv- versions is the correct fix for OS X (and should not break anything on other platforms). Applied and uploaded as 0.32. Thanks! Mattia