Bug #60764 for Time-Piece: Fails to Compile on BeOS5.0 Professional

Thu Aug 26 11:25:04 2010 njh [...] bandsman.co.uk - Ticket created

Subject:

Fails to Compile on BeOS5.0 Professional

I've marked this as critical since this is a blocker for compiling perl 5.12.1. Running Makefile.PL in cpan/Time-Piece ../../miniperl Makefile.PL INSTALLDIRS=perl INSTALLMAN1DIR=none INSTALLMAN3DIR=none PERL_CORE=1 LIBPERL_A=libperl.so LINKTYPE=dynamic Writing Makefile for Time::Piece make[1]: Entering directory `/boot/home/perl-5.12.1/cpan/Time-Piece' make[1]: Leaving directory `/boot/home/perl-5.12.1/cpan/Time-Piece' Making all in cpan/Time-Piece /bin/make all PERL_CORE=1 LIBPERL_A=libperl.so LINKTYPE=dynamic make[1]: Entering directory `/boot/home/perl-5.12.1/cpan/Time-Piece' cp Seconds.pm ../../lib/Time/Seconds.pm cp Piece.pm ../../lib/Time/Piece.pm ../../miniperl "-I../../lib" "-I../../lib" ../../lib/ExtUtils/xsubpp -typemap ../../lib/ExtUtils/typemap Piece.xs > Piece.xsc && /boot/home/perl-5.12.1/cpan/Time-Piece/../../miniperl "-I../../lib" "-I../../lib" -MExtUtils::Command -e 'mv' -- Piece.xsc Piece.c cc -c -I/boot/home/flock_server/src/headers -fno-strict-aliasing -pipe -I/usr/local/include -O -DVERSION=\"1.15_01\" -DXS_VERSION=\"1.15_01\" -fpic "-I../.." Piece.c Running Mkbootstrap for Time::Piece () /boot/home/perl-5.12.1/cpan/Time-Piece/../../miniperl "-I../../lib" "-I../../lib" -MExtUtils::Command -e 'chmod' -- 644 Piece.bs /boot/home/perl-5.12.1/cpan/Time-Piece/../../miniperl "-I../../lib" "-I../../lib" -MExtUtils::Command -e 'rm_f' -- ../../lib/auto/Time/Piece/Piece.so gcc -nostart -L/boot/home/config/lib Piece.o -o ../../lib/auto/Time/Piece/Piece.so \ ../../libperl.so -lnet -lflock -lbe \ Piece.o: In function `XS_Time__Piece__strptime': Piece.o(.text+0xa89): undefined reference to `strptime' collect2: ld returned 1 exit status make[1]: *** [../../lib/auto/Time/Piece/Piece.so] Error 1 make[1]: Leaving directory `/boot/home/perl-5.12.1/cpan/Time-Piece' Unsuccessful make(cpan/Time-Piece): code=2 at make_ext.pl line 449. make: *** [lib/auto/Time/Piece/Piece.so] Error 3

Thu Aug 26 11:41:27 2010 njh [...] bandsman.co.uk - Correspondence added

Subject:	Fails to Compile on BeOS5.0 Professional w/fix
From:	njh [...] bandsman.co.uk

Piece.xs has this statement: "/* Assume everyone has strptime except Win32 and QNX4 */", which is an incorrect assumption :-( There is also an undocumented assumption that all platforms without strptime use strnicmp instead of strncasecmp - this is not the case. This patch fixes these problems: *** OPiece.xs Thu Aug 26 15:37:24 2010 --- Piece.xs Thu Aug 26 15:37:55 2010 *************** *** 306,318 **** #ifndef HAS_STRPTIME /* Assume everyone has strptime except Win32 and QNX4 */ # define HAS_STRPTIME 1 ! # if defined(WIN32) || (defined(__QNX__) && defined(__WATCOMC__)) # undef HAS_STRPTIME # endif #endif #ifndef HAS_STRPTIME #define strncasecmp(x,y,n) strnicmp(x,y,n) #if defined(WIN32) #if defined(__BORLANDC__) --- 306,320 ---- #ifndef HAS_STRPTIME /* Assume everyone has strptime except Win32 and QNX4 */ # define HAS_STRPTIME 1 ! # if defined(WIN32) || defined(__BEOS__) || (defined(__QNX__) && defined(__WATCOMC__)) # undef HAS_STRPTIME # endif #endif #ifndef HAS_STRPTIME + #ifndef __BEOS__ #define strncasecmp(x,y,n) strnicmp(x,y,n) + #endif #if defined(WIN32) #if defined(__BORLANDC__)

Fri Aug 27 10:46:23 2010 msergeant [...] cpan.org - Correspondence added

Does the CPAN version work? It removes any assumption of strptime on any platform and just uses the built in one everywhere.

Fri Aug 27 10:46:23 2010 The RT System itself - Status changed from 'new' to 'open'

Fri Aug 27 12:43:16 2010 njh [...] bandsman.co.uk - Correspondence added

From:

njh [...] bandsman.co.uk

Yes it does, thanks. Is the version that's shipped with Perl going to be fixed? Going to read '/boot/home/.cpan/Metadata' Database was generated on Thu, 26 Aug 2010 08:09:07 GMT Fetching with LWP: http://192.168.1.1/mirrors/CPAN/authors/01mailrc.txt.gz Going to read '/boot/home/.cpan/sources/authors/01mailrc.txt.gz' ............................................................................DONE Fetching with LWP: http://192.168.1.1/mirrors/CPAN/modules/02packages.details.txt.gz Going to read '/boot/home/.cpan/sources/modules/02packages.details.txt.gz' Database was generated on Fri, 27 Aug 2010 06:34:03 GMT ............................................................................DONE Fetching with LWP: http://192.168.1.1/mirrors/CPAN/modules/03modlist.data.gz Going to read '/boot/home/.cpan/sources/modules/03modlist.data.gz' ............................................................................DONE Going to write /boot/home/.cpan/Metadata Running install for module 'Time::Piece' Running make for M/MS/MSERGEANT/Time-Piece-1.20.tar.gz Fetching with LWP: http://192.168.1.1/mirrors/CPAN/authors/id/M/MS/MSERGEANT/Time-Piece-1.20.tar.gz Fetching with LWP: http://192.168.1.1/mirrors/CPAN/authors/id/M/MS/MSERGEANT/CHECKSUMS Checksum for /boot/home/.cpan/sources/authors/id/M/MS/MSERGEANT/Time-Piece-1.20.tar.gz ok Scanning cache /boot/home/.cpan/build for sizes ............................................................................DONE CPAN.pm: Going to build M/MS/MSERGEANT/Time-Piece-1.20.tar.gz CPAN::Reporter: you need Proc::ProcessTable and Proc::Killfam for inactivity_timeout support. Continuing without timeout... Checking if your kit is complete... Looks good Writing Makefile for Time::Piece (/boot/home/config/bin/perl Makefile.PL exited with 0) CPAN::Reporter: Makefile.PL result is 'pass', No errors. cp Seconds.pm blib/lib/Time/Seconds.pm cp Piece.pm blib/lib/Time/Piece.pm /boot/home/config/bin/perl5.12.1 /boot/home/config/lib/perl5/5.12.1/ExtUtils/xsubpp -typemap /boot/home/config/lib/perl5/5.12.1/ExtUtils/typemap Piece.xs > Piece.xsc && /boot/home/config/bin/perl5.12.1 -MExtUtils::Command -e 'mv' -- Piece.xsc Piece.c cc -c -I/boot/home/flock_server/src/headers -fno-strict-aliasing -pipe -I/usr/local/include -O -DVERSION=\"1.20\" -DXS_VERSION=\"1.20\" -fpic "-I/boot/home/config/lib/perl5/5.12.1/BePC-beos/CORE" Piece.c Running Mkbootstrap for Time::Piece () /boot/home/config/bin/perl5.12.1 -MExtUtils::Command -e 'chmod' -- 644 Piece.bs /boot/home/config/bin/perl5.12.1 -MExtUtils::Command -e 'rm_f' -- blib/arch/auto/Time/Piece/Piece.so gcc -nostart -L/boot/home/config/lib Piece.o -o blib/arch/auto/Time/Piece/Piece.so \ /boot/home/config/lib/perl5/5.12.1/BePC-beos/CORE/libperl.so \ /boot/home/config/bin/perl5.12.1 -MExtUtils::Command -e 'chmod' -- 755 blib/arch/auto/Time/Piece/Piece.so /boot/home/config/bin/perl5.12.1 -MExtUtils::Command -e 'cp' -- Piece.bs blib/arch/auto/Time/Piece/Piece.bs /boot/home/config/bin/perl5.12.1 -MExtUtils::Command -e 'chmod' -- 644 blib/arch/auto/Time/Piece/Piece.bs (/bin/make exited with 0) CPAN::Reporter: make result is 'pass', No errors. MSERGEANT/Time-Piece-1.20.tar.gz

Fri Aug 27 14:07:42 2010 matt [...] sergeant.org - Correspondence added

Subject:	Re: [rt.cpan.org #60764] Fails to Compile on BeOS5.0 Professional
Date:	Fri, 27 Aug 2010 14:07:31 -0400
To:	bug-Time-Piece [...] rt.cpan.org
From:	Matt Sergeant <matt [...] sergeant.org>

It should be merged in 5.13... But probably not for 5.12... Though I'll email p5p and see what they say. njh@bandsman.co.uk via RT wrote: Show quoted text

> Yes it does, thanks. Is the version that's shipped with Perl going to be > fixed?

Fri Aug 27 14:22:05 2010 njh [...] bandsman.co.uk - Correspondence added

Subject:	Re: [rt.cpan.org #60764] Fails to Compile on BeOS5.0 Professional
Date:	Fri, 27 Aug 2010 19:21:41 +0100
To:	bug-Time-Piece [...] rt.cpan.org
From:	Nigel Horne <njh [...] bandsman.co.uk>

On 27/08/10 19:07, matt@sergeant.org via RT wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=60764> > > It should be merged in 5.13... But probably not for 5.12... Though I'll > email p5p and see what they say.

Thanks! Show quoted text

> njh@bandsman.co.uk via RT wrote:

>> Yes it does, thanks. Is the version that's shipped with Perl going to be >> fixed?

Sun Jan 02 15:05:29 2011 njh [...] bandsman.co.uk - Correspondence added

From:

njh [...] bandsman.co.uk

5.12.3 is due soon - I've put in a request that this fix make it to there. Let's hope for the best, I see no reason not for it to make it.

Sat Jul 06 11:10:55 2013 rjbs [...] cpan.org - Correspondence added

I believe this was fixed. I will release a new Time::Piece to CPAN with all the fixes from blead today or tomorrow. Please let me know if the problem persists. -- rjbs

Sat Jul 06 11:10:56 2013 rjbs [...] cpan.org - Status changed from 'open' to 'resolved'