Bug #60740 for Dist-Zilla-Plugin-Git:

Wed Aug 25 16:04:45 2010 matt.follett [...] gmail.com - Ticket created

I'm writing a plugin that will be used internally that needs to know the tag name that Git::Tag used to tag the commit. To do that I need _format_tag, so could Dist::Zilla::Plugin::Git::Tag::_format_tag be considered public? I'd hate to use it and then it change at a later day. Alternatively, if you stored the generated tag as an attribute that would be good too. If you think either of these are acceptable and have a preference for one or the other but don't have time I can write the patch up. Thanks, Matt

Thu Aug 26 07:34:54 2010 jquelin [...] cpan.org - Correspondence added

Subject:

could git::tag export _format_tag()?

On Wed Aug 25 16:04:45 2010, mfollett wrote: Show quoted text

> I'm writing a plugin that will be used internally that needs to know the > tag name that Git::Tag used to tag the commit. To do that I need > _format_tag, so could Dist::Zilla::Plugin::Git::Tag::_format_tag be > considered public? I'd hate to use it and then it change at a later > day. Alternatively, if you stored the generated tag as an attribute > that would be good too. > > If you think either of these are acceptable and have a preference for > one or the other but don't have time I can write the patch up.

storing the tag seems better to me, since you'll be sure that _format_tag() is called with the right params. not counting the fact that implementation could change easily if it's hidden. otoh, if we cache the tag, do we also need to cache the message? finally, do you think you'll need the same thing for caching the commit msg in git::commit? so, to sum it up: i'm totally open on merging sthg that can help you. currently, i'd say that hiding the implementation seems saner to me, wdyt?

Thu Aug 26 07:35:05 2010 The RT System itself - Status changed from 'new' to 'open'

Thu Aug 26 09:41:04 2010 matt.follett [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #60740] could git::tag export _format_tag()?
Date:	Thu, 26 Aug 2010 08:40:49 -0500
To:	bug-Dist-Zilla-Plugin-Git [...] rt.cpan.org
From:	Matt Follett <matt.follett [...] gmail.com>

Show quoted text

> storing the tag seems better to me, since you'll be sure that > _format_tag() is called with the right params. not counting the fact > that implementation could change easily if it's hidden.

That's a good point, it'd make more sense to store the tag. I can do that. Show quoted text

> otoh, if we cache the tag, do we also need to cache the message? > finally, do you think you'll need the same thing for caching the commit > msg in git::commit?

I, personally, don't have any need for them. If you think it is something someone else will need I can implement that though. Show quoted text

> so, to sum it up: i'm totally open on merging sthg that can help you. > currently, i'd say that hiding the implementation seems saner to me, wdyt?

I agree, expect a patch for a stored, public version of the tag soon. Thanks, Matt

Mon Aug 30 12:03:39 2010 matt.follett [...] gmail.com - Correspondence added

Subject:	Storing git tag
From:	matt.follett [...] gmail.com

On Thu Aug 26 09:41:04 2010, mfollett wrote: Show quoted text

> I agree, expect a patch for a stored, public version of the tag soon.

I have submitted this to your github repo. Thanks, Matt Follett

Tue Aug 31 11:13:51 2010 jquelin [...] cpan.org - Correspondence added

thanks, applied and shipped in version v1.102430 (i added some documentation for the method)

Tue Aug 31 11:13:52 2010 jquelin [...] cpan.org - Status changed from 'open' to 'resolved'