| Subject: | patch: many more SUSE specific details added |
- added a typical suse header comment to the spec file.
- fixed group:
- used %perl_process_packlist and %perl_gen_filelist
- automatic %files section with sggested %doc README Changes
- reformated the indentation, so that the end result looks good, rather
than the template.
- added several Buildrequires
See also http://wiki.opensuse.org/openSUSE:Packaging_Perl
I call this version 0.01.3 -- it can be found via
http://software.opensuse.org/search?q=perl-CPANPLUS-Dist-SUSE
| Subject: | CPANPLUS::Dist::SUSE.diff |
--- CPANPLUS-Dist-SUSE-0.01/lib/CPANPLUS/Dist/SUSE.pm.orig 2010-03-15 07:46:21.000000000 +0100
+++ CPANPLUS-Dist-SUSE-0.01/lib/CPANPLUS/Dist/SUSE.pm 2010-08-13 21:32:32.181419000 +0200
@@ -17,11 +17,11 @@ CPANPLUS::Dist::SUSE - To build RPM file
=head1 VERSION
-Version 0.01
+Version 0.01.2
=cut
-our $VERSION = '0.01';
+our $VERSION = '0.01.2';
=head1 SYNOPSIS
@@ -168,18 +168,31 @@ sub _is_module_build_compat {
__DATA__
__[ spec ]__
+#
+# spec file for package perl-[% status.rpmname %] (Version [% status.distvers %])
+#
+# Copyright (c) 2010 SUSE LINUX Products GmbH, Nuernberg, Germany.
+# This file and all modifications and additions to the pristine
+# package are under the same license as the package itself.
+#
+# Please submit bugfixes or comments via http://bugs.opensuse.org/
+# See also http://wiki.opensuse.org/openSUSE:Packaging_Perl
+
+# norootforbuild
Name: [% status.rpmname %]
Version: [% status.distvers %]
Release: [% status.rpmvers %]%{?dist}
License: [% status.license %]
-Group: Development/Libraries
+Group: Development/Libraries/Perl
Summary: [% status.summary %]
Source: http://search.cpan.org/CPAN/[% module.path %]/[% status.distname %]-%{version}.[% module.package_extension %]
Url: http://search.cpan.org/dist/[% status.distname %]
-BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
+BuildRoot: %{_tmppath}/%{name}-%{version}-build
Requires: perl = %(eval "`%{__perl} -V:version`"; echo $version)
-[% IF status.is_noarch %]BuildArch: noarch[% END -%]
+[% IF status.is_noarch %]
+BuildArch: noarch
+[% END -%]
[% brs = buildreqs; FOREACH br = brs.keys.sort -%]
BuildRequires: perl([% br %])[% IF (brs.$br != 0) %] >= [% brs.$br %][% END %]
@@ -211,47 +224,47 @@ fi
if [ -f Build.PL ]; then
./Build build flags=%{?_smp_mflags}
else
- make %{?_smp_mflags}
+ %{__make} %{?_smp_mflags}
fi
%install
-rm -rf %{buildroot}
-
if [ -f Build.PL ]; then
./Build pure_install --destdir %{buildroot}
else
- make pure_install PERL_INSTALL_ROOT=%{buildroot}
+ %{__make} pure_install PERL_INSTALL_ROOT=%{buildroot}
fi
- find %{buildroot} -type f -name .packlist -exec rm -f {} ';'
+
+# FIXME: use ./Build install destdir=$RPM_BUILD_ROOT create_packlist=0
+# maybe then we would not need to remove the .packlist files :-)
+find %{buildroot} -type f -name .packlist -exec rm -f {} ';'
+
[% IF (!status.is_noarch) -%]
- find %{buildroot} -type f -name '*.bs' -a -size 0 -exec rm -f {} ';'
+find %{buildroot} -type f -name '*.bs' -a -size 0 -exec rm -f {} ';'
[% END -%]
- find %{buildroot} -depth -type d -exec rmdir {} 2>/dev/null ';'
-
- mkdir -p %{buildroot}/%{_mandir}/man3/ %{buildroot}/usr/bin
- touch %{buildroot}/%{_mandir}/man3/[% status.distname %].3pm.gz
+find %{buildroot} -depth -type d -exec rmdir {} 2>/dev/null ';'
- %{_fixperms} %{buildroot}/*
+%{_fixperms} %{buildroot}/*
+%perl_process_packlist
+%perl_gen_filelist
+[% IF (!skiptest) -%]
%check
if [ -f Build.PL ]; then
./Build test
else
- make test
+ %{__make} test
fi
+[% END -%]
%clean
- rm -rf %{buildroot}
+[ "$RPM_BUILD_ROOT" != "/" ] && [ -d $RPM_BUILD_ROOT ] && %{__rm} -rf $RPM_BUILD_ROOT
-%files
+%files -f %{name}.files
%defattr(-,root,root,-)
-%doc [% docfiles %]
-%{perl_vendorlib}/*
-%{_mandir}/man*/*.*
-/usr/bin
+%doc README Changes
%changelog
-* [% date %] [% packager %] [% status.distvers %]-[% status.rpmvers %]
+* [% date %] [% packager %]
- initial SUSE packaging
- generated with cpan2dist (CPANPLUS::Dist::SUSE version [% packagervers %])
@@ -259,6 +272,10 @@ __[ pod ]__
__END__
+=head1 REFERENCES
+
+L<http://wiki.opensuse.org/openSUSE:Packaging_Perl>
+
=head1 AUTHOR
Qindel Formacion y Servicios, SL, C<< <Nito at Qindel.ES> >>
--- CPANPLUS-Dist-SUSE-0.01/lib/CPANPLUS/Dist/SUSE.pm.orig 2010-08-25 20:54:10.000000000 +0200
+++ CPANPLUS-Dist-SUSE-0.01/lib/CPANPLUS/Dist/SUSE.pm 2010-08-25 21:24:02.000000000 +0200
@@ -17,11 +17,11 @@ CPANPLUS::Dist::SUSE - To build RPM file
=head1 VERSION
-Version 0.01.2
+Version 0.01.3
=cut
-our $VERSION = '0.01.2';
+our $VERSION = '0.01.3';
=head1 SYNOPSIS
@@ -169,7 +169,7 @@ sub _is_module_build_compat {
__DATA__
__[ spec ]__
#
-# spec file for package perl-[% status.rpmname %] (Version [% status.distvers %])
+# spec file for package [% status.rpmname %] (Version [% status.distvers %])
#
# Copyright (c) 2010 SUSE LINUX Products GmbH, Nuernberg, Germany.
# This file and all modifications and additions to the pristine
@@ -196,6 +196,11 @@ BuildArch: noarch
[% brs = buildreqs; FOREACH br = brs.keys.sort -%]
BuildRequires: perl([% br %])[% IF (brs.$br != 0) %] >= [% brs.$br %][% END %]
+BuildRequires: perl(Test::Pod)
+BuildRequires: perl(Test::Pod::Coverage)
+
+#use BuildRequires here, if BuildRecommends fails
+BuildRecommends: perl(Test::CheckManifest)
[% END -%]
@@ -208,23 +213,23 @@ BuildRequires: perl([% br %])[% IF (brs.
%build
[% IF (!status.is_noarch) -%]
- if [ -f Build.PL ]; then
+if [ -f Build.PL ]; then
%{__perl} Build.PL --installdirs vendor
else
[ -f Makefile.PL ] || exit 2
%{__perl} Makefile.PL INSTALLDIRS=vendor OPTIMIZE="%{optflags}"
fi
[% ELSE -%]
- if [ -f Build.PL ]; then
+if [ -f Build.PL ]; then
%{__perl} Build.PL --installdirs vendor
else
%{__perl} Makefile.PL INSTALLDIRS=vendor
fi
[% END -%]
- if [ -f Build.PL ]; then
+if [ -f Build.PL ]; then
./Build build flags=%{?_smp_mflags}
else
- %{__make} %{?_smp_mflags}
+ %{__make} %{?_smp_mflags}
fi
%install
@@ -249,10 +254,13 @@ find %{buildroot} -depth -type d -exec r
[% IF (!skiptest) -%]
%check
- if [ -f Build.PL ]; then
+echo >> MANIFEST.SKIP # ensure trailing newline
+echo >> MANIFEST.SKIP ^%{name}\\.files\$
+
+if [ -f Build.PL ]; then
./Build test
else
- %{__make} test
+ %{__make} test
fi
[% END -%]