| Subject: | Patch against 0.09000_03 for method conflict: type() |
Running tests on Google::Chart 0.09000_03 I get
t/rt42260.t .. You are overwriting a locally defined function (type)
with an accessor
I traced this to a conflict between:
Google::Chart::WithMarker::type()
and
Moose::Util::TypeConstraints::type()
I thought to resolve this by renaming WM::type to WM::markertype
(attached patch). All tests pass for me now.
Moose 1.09
perl, v5.10.0 built for i386-linux-thread-multi
Fedora release 11 (Leonidas)
- Chad
| Subject: | WithMarker.pm.patch |
--- lib/Google/Chart/WithMarker.pm.bak 2010-08-19 15:42:32.235295225 +0200
+++ lib/Google/Chart/WithMarker.pm 2010-08-19 15:42:59.038300960 +0200
@@ -27,7 +27,7 @@
my $markers = $dataset->markers;
foreach my $marker (@$markers) {
push @chm, join(',',
- $marker->type,
+ $marker->markertype,
$marker->color || '',
$i,
!defined $marker->point ? -1 : $marker->point,
@@ -87,7 +87,7 @@
}
;
-has type => (
+has markertype => (
is => 'ro',
isa => 'Google::Chart::DataSet::MarkerType',
);