| Subject: | patch for Pod::Simple 3.14 |
| Date: | Tue, 17 Aug 2010 22:56:39 -0400 |
| To: | bug-Pod-Simple [...] rt.cpan.org |
| From: | Christian Carey <christianc [...] sitesell.com> |
Hello there,
running “make test” against Pod::Simple 3.14 for Perl 5.8.0 on Linux
2.4.21 with HTML::Entities 1.23 installed resulted in two test failures,
both dealing with apostrophes not having been converted to “'”
numeric entities in t/xhtml01.t. The reason for this failure is because
lib/Pod/Simple/XHTML.pm will use HTML::Entities::encode_entities() to
encode entities if it is available. However,
HTML::Entities::encode_entities did not encode apostrophes until version
3.46; with version 1.23 installed, the apostrophes were not converted,
resulting in the test failures.
The attached patch fixes the problem by setting $HAS_HTML_ENTITIES to a
true value only if version 3.46 or later of HTML::Entities is installed.
If you have any questions or concerns regarding this patch, please
feel free to contact me.
Kind regards,
Christian.
Message body is not shown because sender requested not to inline it.