Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Test-TCP CPAN distribution.

Report information
The Basics
Id: 60362
Status: resolved
Priority: 0/
Queue: Test-TCP
People
Owner: Nobody in particular
Requestors: KENTNL [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: Unimportant
Broken in: 1.00
Fixed in: (no value)

History Show all quoted text
  Sun Aug 15 06:52:07 2010 KENTNL [...] cpan.org - Ticket created
Subject: Possibly needless Deps/Files.
I was looking through the code making sure our (Gentoo's ) package management deps properly corresponded to your dists deps, and found a few inconsistencies that might be helpful to remedy. 1. There's fully fledged copies of Test::Base and YAML in inc/ , however, these appear to be used nowhere in the code. 2. As a result of the above, there is a DEP declared in META.yml on Filter::Util::Call , which I can't see a need for. 3. As a result of the above, test_requires 'YAML' in Makefile.PL may also not be needed. You don't have to remedy this, but it would make for a smaller and cleaner distribution if you did =). Thanks.
  Sun Aug 15 09:29:25 2010 tokuhirom [...] gmail.com - Correspondence added
Subject: Re: [rt.cpan.org #60362] Possibly needless Deps/Files.
Date: Sun, 15 Aug 2010 22:29:07 +0900
To: bug-Test-TCP [...] rt.cpan.org
From: Tokuhiro Matsuno <tokuhirom [...] gmail.com>
Hi ketnl, Filter::Util::Call was first released with perl v5.7.3. And other modules are only appeared in inc/. It is not issue. Package maintainer should ignore inc/ and test_requires. But so, I removed deps for these modules for clean up. regards, On Sun, Aug 15, 2010 at 7:52 PM, Kent Fredric via RT <bug-Test-TCP@rt.cpan.org> wrote: Show quoted text
> Sun Aug 15 06:52:07 2010: Request 60362 was acted upon. > Transaction: Ticket created by KENTNL >       Queue: Test-TCP >     Subject: Possibly needless  Deps/Files. >   Broken in: 1.00 >    Severity: Unimportant >       Owner: Nobody >  Requestors: KENTNL@cpan.org >      Status: new >  Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=60362 > > > > I was looking through the code making sure our (Gentoo's ) package > management deps properly corresponded to your dists deps, and found a > few inconsistencies that might be helpful to remedy. > > 1. There's fully fledged copies of Test::Base and YAML  in inc/ , > however, these appear to be used nowhere in the code. > > 2. As a result of the above, there is a DEP declared in META.yml on > Filter::Util::Call  , which I can't see a need for. > > 3. As a result of the above, test_requires 'YAML' in Makefile.PL may > also not be needed. > > You don't have to remedy this, but it would make for a smaller and > cleaner distribution if you did =). > > Thanks. >
  Sun Aug 15 09:29:26 2010 The RT System itself - Status changed from 'new' to 'open'
  Sun Aug 15 09:43:15 2010 tokuhirom+cpan [...] gmail.com - Correspondence added
fixed in 1.01
  Sun Aug 15 09:43:16 2010 tokuhirom+cpan [...] gmail.com - Status changed from 'open' to 'resolved'
  Sun Aug 15 15:47:26 2010 KENTNL [...] cpan.org - Correspondence added
On Sun Aug 15 09:29:25 2010, tokuhirom@gmail.com wrote: Show quoted text
> Filter::Util::Call was first released with perl v5.7.3. And other > modules are only appeared in inc/. It is not issue. > Package maintainer should ignore inc/ and test_requires
We're a source-based distribution, and we like to let our users run tests during installation if they want to =) Show quoted text
> > But so, I removed deps for these modules for clean up.
All the same, thanks =).
  Sun Aug 15 15:47:26 2010 The RT System itself - Status changed from 'resolved' to 'open'
  Sun Aug 15 15:48:13 2010 KENTNL [...] cpan.org - Correspondence added
Silly RT. I didn't tell it to re-open, but it reopened anyway !
  Sun Aug 15 15:48:14 2010 KENTNL [...] cpan.org - Status changed from 'open' to 'resolved'