Skip Menu |

This queue is for tickets about the Dist-Zilla-Plugin-CriticTests CPAN distribution.

Report information
The Basics
Id: 60360
Status: resolved
Priority: 0/
Queue: Dist-Zilla-Plugin-CriticTests
People
Owner: Nobody in particular
Requestors: xenoterracide [...] gmail.com
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Sun Aug 15 02:51:09 2010 xenoterracide [...] gmail.com - Ticket created
Subject: output test doesn't pass use strict
Date: Sun, 15 Aug 2010 02:51:01 -0400
To: bugs-dist-zilla-plugin-critictests [...] rt.cpan.org
From: Caleb Cushing <xenoterracide [...] gmail.com>
running 1.102250 t/author-critic.t ............ Global symbol "$critic_config" requires explicit package name at t/author-critic.t line 19. Global symbol "$critic_config" requires explicit package name at t/author-critic.t line 19. Execution of t/author-critic.t aborted due to compilation errors. -- Caleb Cushing http://xenoterracide.com
  Sun Aug 15 04:07:33 2010 jquelin [...] cpan.org - Correspondence added
i don't really understand how you achieved this, since {{ $critic_config }} is replaced automatically by dist::zilla... i'm rejecting the bug, but please reopen if i misunderstood.
  Sun Aug 15 04:07:34 2010 The RT System itself - Status changed from 'new' to 'open'
  Sun Aug 15 04:07:34 2010 jquelin [...] cpan.org - Status changed from 'open' to 'rejected'
  Sun Aug 15 04:22:03 2010 xenoterracide [...] gmail.com - Correspondence added
Subject: Re: [rt.cpan.org #60360] output test doesn't pass use strict
Date: Sun, 15 Aug 2010 04:21:55 -0400
To: bug-Dist-Zilla-Plugin-CriticTests [...] rt.cpan.org
From: Caleb Cushing <xenoterracide [...] gmail.com>
On Sun, Aug 15, 2010 at 4:07 AM, Jerome Quelin via RT <bug-Dist-Zilla-Plugin-CriticTests@rt.cpan.org> wrote: Show quoted text
> i don't really understand how you achieved this, since {{ $critic_config > }} is replaced automatically by dist::zilla... > > i'm rejecting the bug, but please reopen if i misunderstood.
I don't really understand what you think is replaced? I know nothing about any $critic_config I haven't touched my configuration since the version released before this. I'm not using any config. but if you insist on rejecting the bug I guess I'll just remove the module, I don't have the patience to figure out why this generated test now breaks. -- Caleb Cushing http://xenoterracide.com
  Sun Aug 15 04:22:03 2010 The RT System itself - Status changed from 'rejected' to 'open'
  Sun Aug 15 04:28:21 2010 xenoterracide [...] gmail.com - Correspondence added
Subject: Re: [rt.cpan.org #60360] output test doesn't pass use strict
Date: Sun, 15 Aug 2010 04:28:13 -0400
To: bug-Dist-Zilla-Plugin-CriticTests [...] rt.cpan.org
From: Caleb Cushing <xenoterracide [...] gmail.com>
On Sun, Aug 15, 2010 at 4:21 AM, Caleb Cushing <xenoterracide@gmail.com> wrote: Show quoted text
>> i don't really understand how you achieved this, since {{ $critic_config >> }} is replaced automatically by dist::zilla... >>
I'm going to make an educated guess based on past regressions... this module now requires a critic config, which I don't have, and haven't specified. Thus the var is empty. -- Caleb Cushing http://xenoterracide.com
  Sun Aug 15 04:58:09 2010 jquelin [...] cpan.org - Correspondence added
On Sun Aug 15 04:28:21 2010, XENO wrote: Show quoted text
> I'm going to make an educated guess based on past regressions... this > module now requires a critic config, which I don't have, and haven't > specified. Thus the var is empty.
no, it has a "perlcritic.rc" default. and the test is checking if the file exists before using it. what command did you issue to get this error?
  Sun Aug 15 05:13:13 2010 xenoterracide [...] gmail.com - Correspondence added
Subject: Re: [rt.cpan.org #60360] output test doesn't pass use strict
Date: Sun, 15 Aug 2010 05:13:05 -0400
To: bug-Dist-Zilla-Plugin-CriticTests [...] rt.cpan.org
From: Caleb Cushing <xenoterracide [...] gmail.com>
On Sun, Aug 15, 2010 at 4:58 AM, Jerome Quelin via RT <bug-Dist-Zilla-Plugin-CriticTests@rt.cpan.org> wrote: Show quoted text
> what command did you issue to get this error?
dzil test -- Caleb Cushing http://xenoterracide.com
  Mon Aug 16 13:29:30 2010 jquelin [...] cpan.org - Correspondence added
fixed in 1.102280 thanks to kentl++
  Mon Aug 16 13:29:31 2010 jquelin [...] cpan.org - Status changed from 'open' to 'resolved'