Bug #60247 for Catalyst-Plugin-Unicode-Encoding: Support missing content types: i.e. JSON

Wed Aug 11 10:46:56 2010 abryan+bc [...] pangeamedia.com - Ticket created

Subject:

Support missing content types: i.e. JSON

The MIME type for JSON is application/json, which doesn't get identified as text by the regexp in this module. It would be nice to have to have the ability to override or add to the regexp through a config option.. or at the very least add json$ to the regexp! $c->response->content_type =~ /^text|xml$|javascript$|json$/; -- Andrew Bryan abryan+bc@pangeamedia.com

Wed Aug 11 10:52:18 2010 bobtfish [...] bobtfish.net - Correspondence added

You should be generating JSON using a JSON module / view, which should perform the encoding itself, therefore the unicode plugin should not need to run. Can you give me some more details about what you're doing / why you need the encoding step for JSON output? However, a patch to make the set of content types configurable would be very welcome.

Wed Aug 11 10:52:19 2010 The RT System itself - Status changed from 'new' to 'open'

Wed Aug 11 10:52:23 2010 bobtfish [...] bobtfish.net - Taken

Wed Aug 11 11:18:38 2010 abryan+bc [...] pangeamedia.com - Correspondence added

That's true.. hmmm I'm using JSON::XS and for some reason my encoded output seems to contain wide chars even though utf8 mode is enabled. I might play with it some more, or perhaps I'm reading the documentation incorrectly. Regardless, I still feel this module should explicitly encode JSON if only for consistency. You might, for example, output some JSON that is not created by an encoder. On Wed Aug 11 10:52:18 2010, BOBTFISH wrote: Show quoted text

> You should be generating JSON using a JSON module / view, which should > perform the encoding itself, therefore the unicode plugin should not > need to run. > > Can you give me some more details about what you're doing / why you need > the encoding step for JSON output? > > However, a patch to make the set of content types configurable would be > very welcome.

-- Andrew Bryan abryan+bc@pangeamedia.com

Wed Aug 11 11:30:48 2010 bobtfish [...] bobtfish.net - Correspondence added

On Wed Aug 11 11:18:38 2010, abryan17 wrote: Show quoted text

> That's true.. hmmm I'm using JSON::XS and for some reason my encoded > output seems to contain wide chars even though utf8 mode is enabled. I > might play with it some more, or perhaps I'm reading the documentation > incorrectly.

Can you show me a Devel::Peek::Dump of what JSON::XS is outputting for a trivial case? And what deployment environment are you using / how does your issue manifest? Show quoted text

> Regardless, I still feel this module should explicitly encode JSON if > only for consistency. You might, for example, output some JSON that is > not created by an encoder.

Because everyone like double encoding? :) Being serious, if you're outputting JSON manually, then you're doing it wrong, and I'm happy for the encoding to be broken in that case... Cheers t0m

Wed Aug 11 11:49:37 2010 abryan+bc [...] pangeamedia.com - Correspondence added

Ah.. JSON::XS in View was outputting correctly, but there a useless utf8::decode being applied somewhere before the output was finalized. Once that was removed everything works correctly. I guess changing the regex might not be a much needed feature after all... thanks for humoring me anyway... -- Andrew Bryan abryan+bc@pangeamedia.com

Wed Aug 11 11:54:06 2010 bobtfish [...] bobtfish.net - Correspondence added

On Wed Aug 11 11:49:37 2010, abryan17 wrote: Show quoted text

> Ah.. JSON::XS in View was outputting correctly, but there a useless > utf8::decode being applied somewhere before the output was finalized. > Once that was removed everything works correctly.

Great! Show quoted text

> I guess changing the regex might not be a much needed feature after > all... thanks for humoring me anyway...

I still think it's entirely worthwhile, and I'd still take a patch to do so :) But I'm assuming you're happy now your problem is solved, so I'll resolve this. Cheers t0m

Wed Aug 11 11:54:07 2010 bobtfish [...] bobtfish.net - Status changed from 'open' to 'resolved'