Skip Menu |

This queue is for tickets about the libnet CPAN distribution.

Report information
The Basics
Id: 6024
Status: resolved
Priority: 0/
Queue: libnet
People
Owner: Nobody in particular
Requestors: steve.hay [...] uk.radan.com
Cc:
AdminCc:
Bug Information
Severity: Important
Broken in: 1.18
Fixed in: (no value)

History Show all quoted text
  Thu Apr 15 09:19:57 2004 shay [...] cpan.org - Ticket created
Subject: libnet-1.18 fails t/datasend.t tests 2-15
Hi Graham, Wasn't sure if you spotted this failure already or not. It causes my nightly Smokes to fail -- see: http://www.xray.mpe.mpg.de/mailing-lists/perl5-porters/2004-04/msg00402.html I'm happy to test any fixes you have if you haven't got a Windoze machine handy yourself. Cheers, - Steve
  Thu Apr 15 15:38:55 2004 gbarr [...] pobox.com - Correspondence added
From: Graham Barr <gbarr [...] pobox.com>
Subject: Re: [cpan #6024] libnet-1.18 fails t/datasend.t tests 2-15
Date: Thu, 15 Apr 2004 20:38:20 +0100
To: bug-libnet [...] rt.cpan.org
RT-Send-Cc:
On 15 Apr 2004, at 14:20, via RT wrote: Show quoted text
> Hi Graham, > > Wasn't sure if you spotted this failure already or not. It causes my > nightly Smokes to fail -- see: > > http://www.xray.mpe.mpg.de/mailing-lists/perl5-porters/2004-04/ > msg00402.html
I had not, thanks. Show quoted text
> I'm happy to test any fixes you have if you haven't got a Windoze > machine handy yourself.
It does seem very odd. The test uses a tmp_file, I wonder if that is causing the problem on win32 ? Can you add warn unpack("H*", $line),"\n"; at line 430 in Cmd.pm, just before the while loop. Graham.
  Fri Apr 16 13:51:34 2004 gbarr [...] pobox.com - Correspondence added
From: Graham Barr <gbarr [...] pobox.com>
Subject: Re: [Comment] Re: [cpan #6024] libnet-1.18 fails t/datasend.t tests 2-15
Date: Fri, 16 Apr 2004 18:51:05 +0100
To: bug-libnet [...] rt.cpan.org
RT-Send-Cc:
On 16 Apr 2004, at 08:58, steve.hay@uk.radan.com via RT wrote: Show quoted text
> Graham Barr via RT wrote: >
>> Full context and any attached attachments can be found at: >> <URL: http://rt.cpan.org/NoAuth/Bug.html?id=6024 > >> >> >> It does seem very odd. The test uses a tmp_file, I wonder if that is >> causing the problem on win32 ? >>
> IO::File->new_tmpfile() seems to work fine on Win32. It ultimately > calls win32_tmpfd() in win32/win32.c which is coded using Win32 API > functions (and even opens the file in "binary mode" by default).
Ah OK. I was wondering if it might have been the combination of that and the seek() that I do. And I am still not convinced it is not because the hex from the warn is identical to a clean run here. However, I have decided the Got/Expected output is not clear :-). Please try with http://svn.mutatus.co.uk/browse/libnet/trunk/t/datasend.t Please also keep the warn statement in Cmd.pm too Thanks, Graham.
  Mon Apr 19 08:34:29 2004 gbarr [...] pobox.com - Correspondence added
From: Graham Barr <gbarr [...] pobox.com>
Subject: Re: [Comment] Re: Re: [cpan #6024] libnet-1.18 fails t/datasend.t tests 2-15
Date: Mon, 19 Apr 2004 13:34:13 +0100
To: bug-libnet [...] rt.cpan.org
RT-Send-Cc:
On 19 Apr 2004, at 08:50, steve.hay@uk.radan.com via RT wrote: Show quoted text
> Output is now as below:
Now I am convinced it has something todo with the test using tmp_file and seek(). Looking at the output, regardless of what is send the test always returns the data that the last syswrite sent. Ah, writing that sent alarm bells ringing. IIRC on win32 select(0 only works on pipes, yes ? If so then it could be failing for that reason. If I am right then http://svn.mutatus.co.uk/repos/libnet/trunk/t/datasend.t Should fail on datasend. And the following should fix the error (I think) http://svn.mutatus.co.uk/repos/libnet/trunk/Net/Cmd.pm Graham. Show quoted text
> C:\Temp\libnet-1.18>perl -Mblib t\datasend.t > 1..15 > ok 1 > 61 > not ok 2 > Got: '0d0a2e0d0a' > Expected: '610d0a2e0d0a' > main t\datasend.t 43 > 610d > not ok 3 > Got: '0d0a2e0d0a' > Expected: '610d0d0a2e0d0a' > main t\datasend.t 43 > 610d62 > not ok 4 > Got: '0d0a2e0d0a' > Expected: '610d620d0a2e0d0a' > main t\datasend.t 43 > 610d620d0a > not ok 5 > Got: '2e0d0a' > Expected: '610d620d0a2e0d0a' > main t\datasend.t 43 > 610d620d0a0d0a > not ok 6 > Got: '2e0d0a' > Expected: '610d620d0a0d0a2e0d0a' > main t\datasend.t 43 > 610d > 0a62 > not ok 7 > Got: '0d0a2e0d0a' > Expected: '610d0a620d0a2e0d0a' > main t\datasend.t 43 > 610d > 0a620d0a > not ok 8 > Got: '2e0d0a' > Expected: '610d0a620d0a2e0d0a' > main t\datasend.t 43 > 610d > 0a620d0a > not ok 9 > Got: '2e0d0a' > Expected: '610d0a620d0a2e0d0a' > main t\datasend.t 43 > 610d > 0a620d0a0d0a > not ok 10 > Got: '2e0d0a' > Expected: '610d0a620d0a0d0a2e0d0a' > main t\datasend.t 43 > 610d0a2e2e620d0a > not ok 11 > Got: '2e0d0a' > Expected: '610d0a2e2e620d0a2e0d0a' > main t\datasend.t 43 > 2e2e610d0a2e2e620d0a > not ok 12 > Got: '2e0d0a' > Expected: '2e2e610d0a2e2e620d0a2e0d0a' > main t\datasend.t 43 > 2e2e610d0a > 2e2e620d0a > not ok 13 > Got: '2e0d0a' > Expected: '2e2e610d0a2e2e620d0a2e0d0a' > main t\datasend.t 43 > 2e2e61 > 2e620d0a > not ok 14 > Got: '2e0d0a' > Expected: '2e2e612e620d0a2e0d0a' > main t\datasend.t 43 > 610d0a2e2e > not ok 15 > Got: '0d0a2e0d0a' > Expected: '610d0a2e2e0d0a2e0d0a' > main t\datasend.t 43 > > > > > ------------------------------------------------ > Radan Computational Ltd. > > The information contained in this message and any files transmitted > with it are confidential and intended for the addressee(s) only. If > you have received this message in error or there are any problems, > please notify the sender immediately. The unauthorized use, > disclosure, copying or alteration of this message is strictly > forbidden. Note that any views or opinions presented in this email > are solely those of the author and do not necessarily represent those > of Radan Computational Ltd. The recipient(s) of this message should > check it and any attached files for viruses: Radan Computational will > accept no liability for any damage caused by any virus transmitted by > this email. > > >
  Mon Apr 19 09:49:49 2004 gbarr [...] pobox.com - Correspondence added
From: Graham Barr <gbarr [...] pobox.com>
Subject: Re: [Comment] Re: Re: Re: [cpan #6024] libnet-1.18 fails t/datasend.t tests 2-15
Date: Mon, 19 Apr 2004 14:49:34 +0100
To: bug-libnet [...] rt.cpan.org
RT-Send-Cc:
On 19 Apr 2004, at 14:16, steve.hay@uk.radan.com via RT wrote: Show quoted text
>> >> If so then it could be failing for that reason. If I am right then >> >> http://svn.mutatus.co.uk/repos/libnet/trunk/t/datasend.t >> >> Should fail on datasend. >>
> Yes --
>> And the following should fix the error (I >> think) >> >> http://svn.mutatus.co.uk/repos/libnet/trunk/Net/Cmd.pm >> >>
> Right again --
Excellent. I will do another release shortly and update blead. I have one other issue to resolve first. thanks, Graham.
  Wed Jun 23 05:28:24 2004 shay [...] cpan.org - Correspondence added
[gbarr@pobox.com - Mon Apr 19 09:49:49 2004]: Show quoted text
> >> And the following should fix the error (I > >> think) > >> > >> http://svn.mutatus.co.uk/repos/libnet/trunk/Net/Cmd.pm > >> > >>
> > Right again --
> > Excellent. I will do another release shortly and update blead. I have > one other issue to resolve first.
You may be aware that Nicholas Clark integrated libnet 1.18 into maint-5.8 (change 22790), so these t/datasend.t tests have been failing for some time in that branch as well. I believe that the code freeze for 5.8.5 is June 30th (one week from now). Is there any chance you could roll out a new libnet release with at least these test fixes in before then? It would be nice to have this issue sorted out so that perl-5.8.5 doesn't go out with these tests failing on Win32. Cheers, - Steve
  Thu Oct 07 08:13:29 2004 GBARR [...] CPAN.ORG - Status changed from 'new' to 'resolved'