| To: | bug-IMDB-Movie [...] rt.cpan.org |
| From: | Danial Pearce <danial [...] infoxchange.net.au> |
| Subject: | Taglines/Plots patch |
| Date: | Wed, 14 Apr 2004 23:37:30 +1000 |
Ok, here we go again.
Patch attached.
I had to combine the tag/plot capturing into one function, in case
either are missing.
I also added a trailing '/' to the HTTP request as it was causing me
some grief without it. When doing a tcpdump of what was happening on my
failed requests, you can see that IMDB is really doing a redirect to
the URL with a trailing / anyway, so this really makes no difference.
Also, I think it's fair to return no object when creating the object
fails? So that the calling code can tell that the object wasn't created
successfully.
I had to add the 'br' tag to the genre searching, because some movies
E.g. Ghost in the Shell, don't end the genre line with "(more)".
Anyway, the patch is yours to do with as you see fit. Delete it, or
apply it :)
Last thing, which I've no idea how to fix, pretty much nothing works
for movies with movies that are in production, E.g. Indiana Jones 4.
Not much can be done about this, but may be worthwhile adding it to the
known bugs area.
--
Danial Pearce
Analyst/Programmer
Infoxchange Australia
Message body is not shown because sender requested not to inline it.