Bug #60133 for Devel-REPL: [PATCH 1/4] rename Default profile to Minimal

Fri Aug 06 04:10:10 2010 xenoterracide [...] gmail.com - Ticket created

CC:	Caleb Cushing <xenoterracide [...] gmail.com>
Subject:	[PATCH 1/4] rename Default profile to Minimal
Date:	Fri, 6 Aug 2010 04:09:35 -0400
To:	bug-devel-repl [...] rt.cpan.org
From:	Caleb Cushing <xenoterracide [...] gmail.com>

Signed-off-by: Caleb Cushing <xenoterracide@gmail.com> --- part one of requested patches by MST. Since Readline is now on by default one of the 2 readline libraries will need to be a dependancy. Also docs should be written on how to switch profiles in repl.rc (I don't know how). Unloading a single plugin would be good too. lib/Devel/REPL/Profile/{Default.pm => Minimal.pm} | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) rename lib/Devel/REPL/Profile/{Default.pm => Minimal.pm} (86%) diff --git a/lib/Devel/REPL/Profile/Default.pm b/lib/Devel/REPL/Profile/Minimal.pm similarity index 86% rename from lib/Devel/REPL/Profile/Default.pm rename to lib/Devel/REPL/Profile/Minimal.pm index b698d9f..2b03ac9 100644 --- a/lib/Devel/REPL/Profile/Default.pm +++ b/lib/Devel/REPL/Profile/Minimal.pm @@ -1,4 +1,4 @@ -package Devel::REPL::Profile::Default; +package Devel::REPL::Profile::Minimal; use Moose; use namespace::clean -except => [ 'meta' ]; -- 1.7.2.1

Sat Aug 14 13:16:35 2010 chm [...] cpan.org - Correspondence added

On Fri Aug 06 04:10:10 2010, XENO wrote: Show quoted text

> Signed-off-by: Caleb Cushing <xenoterracide@gmail.com> > --- > part one of requested patches by MST. Since Readline is now on by > default one of the 2 readline libraries will need to be a > dependancy. Also docs should be written on how to switch profiles > in repl.rc (I don't know how). > Unloading a single plugin would be good too.

Actually, MST requested the readline completion be turned off by default which it is in Devel-REPL-1.003011. However, Term::ReadLine has *always* been a requirement for REPL.pm since the entire implementation is based on it. I did not realize that it was not already listed as as dependency. --Chris Show quoted text

> lib/Devel/REPL/Profile/{Default.pm => Minimal.pm} | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > rename lib/Devel/REPL/Profile/{Default.pm => Minimal.pm} (86%) > > diff --git a/lib/Devel/REPL/Profile/Default.pm > b/lib/Devel/REPL/Profile/Minimal.pm > similarity index 86% > rename from lib/Devel/REPL/Profile/Default.pm > rename to lib/Devel/REPL/Profile/Minimal.pm > index b698d9f..2b03ac9 100644 > --- a/lib/Devel/REPL/Profile/Default.pm > +++ b/lib/Devel/REPL/Profile/Minimal.pm > @@ -1,4 +1,4 @@ > -package Devel::REPL::Profile::Default; > +package Devel::REPL::Profile::Minimal; > > use Moose; > use namespace::clean -except => [ 'meta' ];

Sat Aug 14 13:16:39 2010 The RT System itself - Status changed from 'new' to 'open'

Sat Aug 14 14:27:46 2010 xenoterracide [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #60133] [PATCH 1/4] rename Default profile to Minimal
Date:	Sat, 14 Aug 2010 14:27:37 -0400
To:	bug-Devel-REPL [...] rt.cpan.org
From:	Caleb Cushing <xenoterracide [...] gmail.com>

On Sat, Aug 14, 2010 at 1:16 PM, Chris Marshall via RT <bug-Devel-REPL@rt.cpan.org> wrote: Show quoted text

> Actually, MST requested the readline completion be > turned off by default which it is in Devel-REPL-1.003011.

don't know any thing about that, he asked me to make the defaults more user friendly Show quoted text

> However, Term::ReadLine has *always* been a requirement > for REPL.pm since the entire implementation is based on > it. I did not realize that it was not already listed as > as dependency.

Yeah but there's the whole are you using ::Perl or ::Gnu implementation. I remember because when I first enabled it crashed and spit an error saying I must have one of those installed. -- Caleb Cushing http://xenoterracide.com

Sun Aug 15 09:28:53 2010 chm [...] cpan.org - Correspondence added

On Sat Aug 14 14:27:46 2010, XENO wrote: Show quoted text

> On Sat, Aug 14, 2010 at 1:16 PM, Chris Marshall via RT > <bug-Devel-REPL@rt.cpan.org> wrote:

> > Actually, MST requested the readline completion be > > turned off by default which it is in Devel-REPL-1.003011.

> > don't know any thing about that, he asked me to make the > defaults more user friendly >

> > However, Term::ReadLine has *always* been a requirement > > for REPL.pm since the entire implementation is based on > > it. I did not realize that it was not already listed as > > as dependency.

> > Yeah but there's the whole are you using ::Perl or ::Gnu > implementation. I remember because when I first enabled it crashed and > spit an error saying I must have one of those installed.

I see what you mean. We're in a the final stages of the PDL-2.4.7 release process and a tester had problems when only Term::ReadLine::Stub was present. I'll be taking a look at the Devel::REPL code to make it PERL_RL=Stub safe but I may not get to it until after our release. --Chris

Sun Feb 13 21:42:10 2011 chm [...] cpan.org - Status changed from 'open' to 'patched'

Fri Mar 01 13:37:39 2013 ether [...] cpan.org - Correspondence added

We have a 'Default' and a 'Minimal' profile; how should we proceed?

Fri Mar 01 13:37:48 2013 The RT System itself - Status changed from 'patched' to 'open'

Fri Mar 01 19:53:19 2013 xenoterracide [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #60133] [PATCH 1/4] rename Default profile to Minimal
Date:	Fri, 1 Mar 2013 18:53:07 -0600
To:	bug-Devel-REPL [...] rt.cpan.org
From:	Caleb Cushing <xenoterracide [...] gmail.com>

it looks like all 4 patches were set to status "patch" a while ago... I have to be honest though I barely remember what this was about. It was probably to make the defaults nicer, so if that's been accomplished? On Fri, Mar 1, 2013 at 12:37 PM, Karen Etheridge via RT <bug-Devel-REPL@rt.cpan.org> wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=60133 > > > We have a 'Default' and a 'Minimal' profile; how should we proceed?

-- Caleb Cushing http://xenoterracide.com