| Subject: | [PATCH] Tests can fail in chroots |
| Date: | Thu, 05 Aug 2010 14:56:00 +0900 |
| To: | bug-Sys-Statistics-Linux [...] rt.cpan.org |
| From: | Ansgar Burchardt <ANSGAR [...] cpan.org> |
Hi,
the tests involving df fail in chroot environments as they assume that
df will always return information on at least one filesystem. This is
not true for all chroots: here df might just write (to stderr)
df: no file systems processed
and nothing else.
Two tests then fail:
Show quoted text
> df: no file systems processed
> # No tests run!
> t/090-diskusage.t .....
> Dubious, test returned 255 (wstat 65280, 0xff00)
> Failed 5/5 subtests
Show quoted text > df: no file systems processed
>
> # Failed test 'checking diskusage'
> # at t/130-search.t line 29.
> # Looks like you failed 1 test of 10.
> t/130-search.t ........
This was also reported on Debian [1] where all packages are rebuild in a
chroot environment automatically.
The attached patch skips the tests if df returns nothing. Also stderr
is redirected to /dev/null when calling df to prevent the message above
from being displayed. Please consider applying it for the next release.
Regards,
Ansgar
[1] <http://bugs.debian.org/591123>
Message body is not shown because sender requested not to inline it.