Skip Menu |

This queue is for tickets about the SQL-Shell CPAN distribution.

Report information
The Basics
Id: 60016
Status: resolved
Priority: 0/
Queue: SQL-Shell

People
Owner: Nobody in particular
Requestors: randy [...] magnificent-tears.com
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 1.14
Fixed in: 1.14_02



Subject: sqlsh fails to load history by default
When attempting to load user's history sqlsh checks the existence of HISTORY_FILE constant without expanding it. The call to save_history calls _expand_filename(HISTORY_FILE), however the load call simply checks -f HISTORY_FILE. SQL-Shell-1.14 (sqlsh $VERSION 1.50) This is perl, v5.10.1 (*) built for i486-linux-gnu-thread-multi Linux 2.6.32-24-generic #38-Ubuntu SMP Mon Jul 5 09:22:14 UTC 2010 i686 GNU/Linux [Unified Diff] Patch file attached. [Normal] Diff: 103c103 < $sqlsh->load_history(HISTORY_FILE) if(-f HISTORY_FILE); --- Show quoted text
> $sqlsh->load_history(HISTORY_FILE) if(-f
_expand_filename(HISTORY_FILE));
Subject: sqlsh-load_history.patch
--- orig/sqlsh +++ patched/sqlsh @@ -100,7 +100,7 @@ }); #Load any previous history - $sqlsh->load_history(HISTORY_FILE) if(-f HISTORY_FILE); + $sqlsh->load_history(HISTORY_FILE) if(-f _expand_filename(HISTORY_FILE)); #Command loop local $_;
Resolved in 1.14_02 and subsequent releases.