Skip Menu |

This queue is for tickets about the Authen-Bitcard CPAN distribution.

Report information
The Basics
Id: 59919
Status: resolved
Priority: 0/
Queue: Authen-Bitcard

People
Owner: Nobody in particular
Requestors: ansgar [...] 43-1.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: [PATCH] Use Digest::SHA instead of Digest::SHA1
Date: Sat, 31 Jul 2010 21:03:44 +0900
To: bug-Authen-Bitcard [...] rt.cpan.org
From: Ansgar Burchardt <ansgar [...] 43-1.org>
Hi, the attached patch changes Authen::Bitcard to use the Digest::SHA module instead of Digest::SHA1. Digest::SHA is part of the standard perl distribution since perl v5.9.3 so this reduces the number of external dependencies by one. Please consider applying it for the next release. Regards, Ansgar
only in patch2: unchanged: --- libauthen-bitcard-perl-0.86.orig/Makefile.PL +++ libauthen-bitcard-perl-0.86/Makefile.PL @@ -12,7 +12,7 @@ 'Test::More' => 0, 'Math::BigInt' => 0, 'MIME::Base64' => 0, - 'Digest::SHA1' => 0, + 'Digest::SHA' => 0, 'LWP::UserAgent' => 0, 'HTTP::Status' => 0, 'URI' => 1.22, only in patch2: unchanged: --- libauthen-bitcard-perl-0.86.orig/lib/Authen/Bitcard.pm +++ libauthen-bitcard-perl-0.86/lib/Authen/Bitcard.pm @@ -4,7 +4,7 @@ use Math::BigInt lib => 'GMP,Pari'; use MIME::Base64 qw( decode_base64 ); -use Digest::SHA1 qw( sha1 ); +use Digest::SHA qw( sha1 ); use LWP::UserAgent; use HTTP::Status qw( RC_NOT_MODIFIED ); use URI;
Fixed, thanks!