Skip Menu |

This queue is for tickets about the Kephra CPAN distribution.

Report information
The Basics
Id: 59886
Status: resolved
Worked: 2 min
Priority: 0/
Queue: Kephra

People
Owner: sir_lichtkind [...] sourceforge.net
Requestors: jozef [...] kutej.net
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 0.4.3.0
Fixed in: (no value)



Hi Herbert, the tests are failing on my machine, see below. Attached is a patch that made the test pass. If you need more information just let me know. Cheers Jozef ---cut--- Kephra-0.4.3.0$ make test PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'inc', 'blib/lib', 'blib/arch')" t/*.t t/01_compile.t ......... 7/76 # Failed test 'require Kephra::Dialog::Exit;' # at t/01_compile.t line 43. # Tried to require 'Kephra::Dialog::Exit'. # Error: Can't use bareword ("Kephra::Config::Localisation::strings") as a HASH ref while "strict refs" in use at lib/Kephra/Dialog/Exit.pm line 39. # Compilation failed in require at (eval 66) line 2. # Failed test 'require Kephra::App::Window;' # at t/01_compile.t line 43. # Tried to require 'Kephra::App::Window'. # Error: Bareword "Kephra::App::MainToolBar::get_visibility" not allowed while "strict subs" in use at lib/Kephra/App/Window.pm line 125. # Bareword "Kephra::App::TabBar::get_visibility" not allowed while "strict subs" in use at lib/Kephra/App/Window.pm line 127. # Bareword "Kephra::App::SearchBar::get_visibility" not allowed while "strict subs" in use at lib/Kephra/App/Window.pm line 129. # Bareword "Kephra::App::StatusBar::get_visibility" not allowed while "strict subs" in use at lib/Kephra/App/Window.pm line 131. # Compilation failed in require at (eval 87) line 2. # Looks like you failed 2 tests of 76. t/01_compile.t ......... Dubious, test returned 2 (wstat 512, 0x200) Failed 2/76 subtests (1 TODO test unexpectedly succeeded) t/02_config.t .......... ok t/03_config_default.t .. ok t/10_new.t ............. ok Test Summary Report ------------------- t/01_compile.t (Wstat: 512 Tests: 76 Failed: 2) Failed tests: 24, 45 TODO passed: 75 Non-zero exit status: 2 Files=4, Tests=79, 3 wallclock secs ( 0.05 usr 0.01 sys + 0.56 cusr 0.12 csys = 0.74 CPU) Result: FAIL Failed 1/4 test programs. 2/79 subtests failed. make: *** [test_dynamic] Error 255
Subject: fix-tests-with-use.patch
diff -Naur Kephra-0.4.3.0.orig/lib/Kephra/App/Window.pm Kephra-0.4.3.0/lib/Kephra/App/Window.pm --- Kephra-0.4.3.0.orig/lib/Kephra/App/Window.pm 2010-06-22 17:58:55.000000000 +0200 +++ Kephra-0.4.3.0/lib/Kephra/App/Window.pm 2010-07-30 21:18:46.000000000 +0200 @@ -4,6 +4,11 @@ use strict; use warnings; +use Kephra::App::MainToolBar; +use Kephra::App::SearchBar; +use Kephra::App::TabBar; +use Kephra::App::StatusBar; + my $frame; sub _ref { if (ref $_[0] eq 'Wx::Frame'){ $frame = $_[0] } else { $frame } } sub _config { Kephra::API::settings()->{app}{window} } diff -Naur Kephra-0.4.3.0.orig/lib/Kephra/Dialog/Exit.pm Kephra-0.4.3.0/lib/Kephra/Dialog/Exit.pm --- Kephra-0.4.3.0.orig/lib/Kephra/Dialog/Exit.pm 2009-12-02 00:36:21.000000000 +0100 +++ Kephra-0.4.3.0/lib/Kephra/Dialog/Exit.pm 2010-07-30 21:16:45.000000000 +0200 @@ -4,6 +4,7 @@ use strict; use warnings; +use Kephra::Config::Localisation; sub save_on_exit {