Skip Menu |

This queue is for tickets about the Spreadsheet-Read CPAN distribution.

Report information
The Basics
Id: 59859
Status: rejected
Priority: 0/
Queue: Spreadsheet-Read

People
Owner: Nobody in particular
Requestors: alan [...] alanjames.org
Cc:
AdminCc:

Bug Information
Severity: Unimportant
Broken in: (no value)
Fixed in: (no value)



Subject: Carriage return line endings not working in CSV files
Date: Fri, 30 Jul 2010 11:52:28 +0100
To: bug-Spreadsheet-Read [...] rt.cpan.org
From: Alan James <alan [...] alanjames.org>
Hi, When SpreadSheet::Read 0.40 is using Text-CSV_XS it cannot correctly parse files with carriage return line endings unless $/ and eol are both set to CR. The attached patch allows the line ending to be set manually (and the quote char too), but auto detection would be better if possible. Thanks, Alan.

Message body is not shown because sender requested not to inline it.

Subject: Re: [rt.cpan.org #59859] Carriage return line endings not working in CSV files
Date: Sat, 31 Jul 2010 10:42:53 +0200
To: bug-Spreadsheet-Read [...] rt.cpan.org
From: "H.Merijn Brand" <h.m.brand [...] xs4all.nl>
On Fri, 30 Jul 2010 06:52:59 -0400, "Alan James via RT" <bug-Spreadsheet-Read@rt.cpan.org> wrote: Show quoted text
> When SpreadSheet::Read 0.40 is using Text-CSV_XS it cannot correctly > parse files with carriage return line endings unless $/ and eol are > both set to CR.
Depends on which version of Text::CSV_XS you run. As of version 0.69 that should be working fine: 2009-10-10 0.69 - H.Merijn Brand <h.m.brand@xs4all.nl> * Missing end quotes in error code docs * examples/csv-check now shows detected eol * Auto detection of eol => "\r" in streams * Optimized caching. All cache changes now in XS Show quoted text
> The attached patch allows the line ending to be set manually (and the > quote char too), but auto detection would be better if possible.
Current version for Text::CSV_XS is 0.73 As for the possibility to be able to pass all of these attributes, I think it is a good idea. I might do that in the next release. -- H.Merijn Brand http://tux.nl Perl Monger http://amsterdam.pm.org/ using 5.00307 through 5.12 and porting perl5.13.x on HP-UX 10.20, 11.00, 11.11, 11.23, and 11.31, OpenSuSE 10.3, 11.0, and 11.1, AIX 5.2 and 5.3. http://mirrors.develooper.com/hpux/ http://www.test-smoke.org/ http://qa.perl.org http://www.goldmark.org/jeff/stupid-disclaimers/
Subject: Re: [rt.cpan.org #59859] Carriage return line endings not working in CSV files
Date: Sat, 31 Jul 2010 09:49:42 +0100
To: bug-Spreadsheet-Read [...] rt.cpan.org
From: Alan James <alan [...] alanjames.org>
You're right. Looks like I have a rather old version here (0.52). I'll upgrade. Thanks, Alan. On 31 July 2010 09:43, h.m.brand@xs4all.nl via RT <bug-Spreadsheet-Read@rt.cpan.org> wrote: Show quoted text
> <URL: http://rt.cpan.org/Ticket/Display.html?id=59859 > > > On Fri, 30 Jul 2010 06:52:59 -0400, "Alan James via RT" > <bug-Spreadsheet-Read@rt.cpan.org> wrote: >
>> When SpreadSheet::Read 0.40 is using Text-CSV_XS it cannot correctly >> parse files with carriage return line endings unless $/ and eol are >> both set to CR.
> > Depends on which version of Text::CSV_XS you run. > > As of version 0.69 that should be working fine: > > 2009-10-10 0.69 - H.Merijn Brand   <h.m.brand@xs4all.nl> > >    * Missing end quotes in error code docs >    * examples/csv-check now shows detected eol >    * Auto detection of eol => "\r" in streams >    * Optimized caching. All cache changes now in XS >
>> The attached patch allows the line ending to be set manually (and the >> quote char too), but auto detection would be better if possible.
> > Current version for Text::CSV_XS is 0.73 > > As for the possibility to be able to pass all of these attributes, I > think it is a good idea. I might do that in the next release. > > -- > H.Merijn Brand  http://tux.nl      Perl Monger  http://amsterdam.pm.org/ > using 5.00307 through 5.12 and porting perl5.13.x on HP-UX 10.20, 11.00, > 11.11, 11.23, and 11.31, OpenSuSE 10.3, 11.0, and 11.1, AIX 5.2 and 5.3. > http://mirrors.develooper.com/hpux/           http://www.test-smoke.org/ > http://qa.perl.org      http://www.goldmark.org/jeff/stupid-disclaimers/ > >