Skip Menu |

This queue is for tickets about the IMDB-Movie CPAN distribution.

Report information
The Basics
Id: 5985
Status: rejected
Priority: 0/
Queue: IMDB-Movie

People
Owner: Nobody in particular
Requestors: danial [...] infoxchange.net.au
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



From: Danial Pearce <danial [...] infoxchange.net.au>
Subject: Re: Not a bug, feature addition... patch attached.
Date: Tue, 13 Apr 2004 00:03:12 +1000
To: bug-IMDB-Movie [...] rt.cpan.org
On 12 Apr 2004, at 11:11 PM, Danial Pearce wrote: Show quoted text
> Love your work on the IDMB module. > > I have altered it slightly to include capture the tagline and plot > fields as well.
Ok, ignore that last patch. I realise why you aren't grabbing taglines and plots is cos not every movie has them (A Few Good Men), and if you try and get them, you stuff the rest of the parsing up. I will think of a way around this and get back to you, but it's bed time now. regards, Danial Pearce Analyst/Programmer Infoxchange Australia
[danial@infoxchange.net.au - Mon Apr 12 10:03:14 2004]: Show quoted text
> On 12 Apr 2004, at 11:11 PM, Danial Pearce wrote:
> > Love your work on the IDMB module. > > > > I have altered it slightly to include capture the tagline and plot > > fields as well.
> > Ok, ignore that last patch. I realise why you aren't grabbing taglines > and plots is cos not every movie has them (A Few Good Men), and if you > try and get them, you stuff the rest of the parsing up. > > I will think of a way around this and get back to you, but it's bed > time now. > > regards, > Danial Pearce > Analyst/Programmer > Infoxchange Australia >
This gets the plot for a few good men (tt0104257) -------8<--------------------------------- sub _plot { my $parser = shift; my ($tag, $plot); while ($tag = $parser->get_tag('b')) { if ($tag->[1]->{class}){ last if( $parser->get_text() =~ /Plot/io); } } # pop the next one off the stack (we dont need it) $parser->get_token; $plot = $parser->get_token; $plot->[1] =~ s/^\s//g; return $plot->[1]; } -------8<---------------------------------
From: ryszard
I forgot to include the other parts of the module i changed. please find attached the entire module.

Message body is not shown because it is too large.

Subject: IMDB::Movie on hold
Thanks to everyone for submitting these bug reports. I am planning on rewriting IMDB::Movie (using WWW::Mechanize this time) and i will review all of these bugs/feature requests/patches when i write it. jeffa
use IMDB::Film;