Bug #59768 for App-SVN-Bisect: yaml returns ARRAY

Wed Jul 28 05:54:03 2010 RURBAN [...] cpan.org - Ticket created

Subject:

yaml returns ARRAY

My YAML-Syck-1.07 returns an arrayref for Load(io($metadata)->all) (a proper .svn/bisect.yaml), so I suggest the following patch: diff -u lib/App/SVN/Bisect.pm~ lib/App/SVN/Bisect.pm --- lib/App/SVN/Bisect.pm~ 2009-12-04 16:57:40.000000000 +0100 +++ lib/App/SVN/Bisect.pm 2010-07-28 11:49:15.524070900 +0200 @@ -80,7 +80,8 @@ if($actions{$action}{read_config}) { die("A bisect is not in progress! Try \"$0 help start\".\n") unless -f $metadata; - $$self{config} = Load(io($metadata)->all); + my $yaml = Load(io($metadata)->all); + $$self{config} = ref $yaml eq 'ARRAY' ? $yaml->[0] : $yaml; } return bless($self, $package); } -- Reini Urban

Wed Jul 28 06:05:17 2010 INFINOID [...] cpan.org - Correspondence added

On Wed Jul 28 05:54:03 2010, RURBAN wrote: Show quoted text

> My YAML-Syck-1.07 returns an arrayref for Load(io($metadata)->all) (a > proper .svn/bisect.yaml)

Thanks for the report and the patch. I'd like to try to understand this issue a little better. I am also using YAML::Syck version 1.07, and I have not seen this behavior. What exactly is it returning? Is there more than one entry in this top level array? Is your io($metadata)->all returning a single scalar value, or a list?

Wed Jul 28 06:05:18 2010 The RT System itself - Status changed from 'new' to 'open'

Wed Jul 28 06:12:48 2010 INFINOID [...] cpan.org - Taken

Wed Jul 28 11:51:16 2010 rurban [...] x-ray.at - Correspondence added

CC:	RURBAN [...] cpan.org
Subject:	Re: [rt.cpan.org #59768] yaml returns ARRAY
Date:	Wed, 28 Jul 2010 17:51:00 +0200
To:	bug-App-SVN-Bisect [...] rt.cpan.org
From:	Reini Urban <rurban [...] x-ray.at>

Mark Glines via RT schrieb: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=59768> > > On Wed Jul 28 05:54:03 2010, RURBAN wrote:

>> My YAML-Syck-1.07 returns an arrayref for Load(io($metadata)->all) (a >> proper .svn/bisect.yaml)

> > Thanks for the report and the patch. > > I'd like to try to understand this issue a little better. I am also > using YAML::Syck version 1.07, and I have not seen this behavior. What > exactly is it returning? Is there more than one entry in this top level > array? Is your io($metadata)->all returning a single scalar value, or a > list?

I'm also not understanding it. The same version worked for me before for sure, I did some bisecting before with the same versions: YAML::Syck and your module. io($metadata)->all is returning a string, like '--- orig: 95 skip: {} ' and now at home it works: x Load(io($metadata)->all) 0 HASH(0x1839708) 'orig' => 95 'skip' => HASH(0x18396a8) empty hash On my company laptop with Windows 7 and cygwin perl, Load returned an ARRAYREF. Wait with this patch until I investigate again. Maybe it's some antivir hook which garbles IO. I also have a weird problem with GetOpts::Long ignoring --min <val> --max <val>, which I fixed by removing the module options. Then it worked. -- Reini Urban http://phpwiki.org/ http://murbreak.at/

Wed Aug 04 07:23:45 2010 INFINOID [...] cpan.org - Correspondence added

On Wed Jul 28 11:51:16 2010, rurban@x-ray.at wrote: Show quoted text

> On my company laptop with Windows 7 and cygwin perl, > Load returned an ARRAYREF. > Wait with this patch until I investigate again. > Maybe it's some antivir hook which garbles IO.

Okay. If it is valid for Syck to return an arrayref in this context, I can certainly put in the workaround you proposed. However, I am still wondering why it changed behavior, and if I'm somehow either calling Load wrongly, or else generating the save-file wrongly. If so, I'd rather fix that than work around it. So please let me know what you find. Thanks!

Sun Aug 29 07:30:14 2010 INFINOID [...] cpan.org - Correspondence added

On Wed Jul 28 11:51:16 2010, rurban@x-ray.at wrote: Show quoted text

> and now at home it works: > x Load(io($metadata)->all) > 0 HASH(0x1839708) > 'orig' => 95 > 'skip' => HASH(0x18396a8) > empty hash > > On my company laptop with Windows 7 and cygwin perl, > Load returned an ARRAYREF. > Wait with this patch until I investigate again. > Maybe it's some antivir hook which garbles IO.

Ping? Any update on this? I still cannot reproduce the problem here.

Sun Aug 29 09:15:47 2010 rurban [...] x-ray.at - Correspondence added

CC:	RURBAN [...] cpan.org
Subject:	Re: [rt.cpan.org #59768] yaml returns ARRAY
Date:	Sun, 29 Aug 2010 15:15:30 +0200
To:	bug-App-SVN-Bisect [...] rt.cpan.org
From:	Reini Urban <rurban [...] x-ray.at>

2010/8/29 Mark Glines via RT <bug-App-SVN-Bisect@rt.cpan.org>: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=59768 > > > On Wed Jul 28 11:51:16 2010, rurban@x-ray.at wrote:

>> and now at home it works: >> x Load(io($metadata)->all) >> 0 HASH(0x1839708) >> 'orig' => 95 >> 'skip' => HASH(0x18396a8) >> empty hash >> >> On my company laptop with Windows 7 and cygwin perl, >> Load returned an ARRAYREF. >> Wait with this patch until I investigate again. >> Maybe it's some antivir hook which garbles IO.

> > Ping? Any update on this? > > I still cannot reproduce the problem here.

Sorry. I forgot it. Lets close it as bogus. -- Reini Urban

Sun Aug 29 09:45:17 2010 INFINOID [...] cpan.org - Correspondence added

Ok, closed as rejected. If you do see it again and can get more info, or if you have additional problems on windows 7 and/or cygwin perl, please reopen or re-file. In the meantime, I'll make a new release with patches for a few other tickets. Thanks!

Sun Aug 29 09:45:18 2010 INFINOID [...] cpan.org - Status changed from 'open' to 'rejected'