Bug #59766 for App-SVN-Bisect: remove cwd on windows fails

Wed Jul 28 04:30:35 2010 RURBAN [...] cpan.org - Ticket created

Subject:

remove cwd on windows fails

t/01_basic_operation.t tries to remove the current workdir from File::Temp which fails on Windows and cygwin. ok 72 - verbose cannot remove path when cwd is /tmp/CXwjsMambt for /tmp/CXwjsMambt: at /usr/lib/perl5/5.13.3/File/Temp.pm line 902 Attached patch sanifies this. -- Reini Urban

Subject:

App-SVN-Bisect-wintempdir.patch

diffbk App-SVN-Bisect-1.0 diff -u App-SVN-Bisect-1.0/t/01_basic_operation.t~ App-SVN-Bisect-1.0/t/01_basic_operation.t --- App-SVN-Bisect-1.0/t/01_basic_operation.t~ 2009-12-04 16:57:40.000000000 +0100 +++ App-SVN-Bisect-1.0/t/01_basic_operation.t 2010-07-28 10:25:44.790465700 +0200 @@ -2,6 +2,7 @@ use warnings; use File::Temp qw(tempdir); +use Cwd qw(getcwd); use Test::More; use Test::Exception; use Test::Output; @@ -12,6 +13,7 @@ BEGIN { $tests = 0; }; plan tests => $tests; +my $curdir = getcwd(); my $tempdir = tempdir( CLEANUP => 1 ); chdir($tempdir); mkdir(".svn"); @@ -294,5 +296,6 @@ # test ->exit() +chdir $curdir; App::SVN::Bisect->exit(0); exit(1);

Wed Jul 28 06:12:31 2010 INFINOID [...] cpan.org - Correspondence added

On Wed Jul 28 04:30:35 2010, RURBAN wrote: Show quoted text

> Attached patch sanifies this.

Thanks, the patch looks reasonable to me. Though it looks like Cwd is not part of the base Perl installation (at least not in 5.10 and 5.12), so I think I would have to add that to the list of prerequisites as well. Would a simple chdir("/") suffice, or some portable equivalent of that?

Wed Jul 28 06:12:32 2010 The RT System itself - Status changed from 'new' to 'open'

Wed Jul 28 06:12:44 2010 INFINOID [...] cpan.org - Taken

Wed Jul 28 11:38:54 2010 rurban [...] x-ray.at - Correspondence added

Subject:	Re: [rt.cpan.org #59766] remove cwd on windows fails
Date:	Wed, 28 Jul 2010 17:38:42 +0200
To:	bug-App-SVN-Bisect [...] rt.cpan.org
From:	Reini Urban <rurban [...] x-ray.at>

Hi Mark, Mark Glines via RT schrieb: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=59766> > > On Wed Jul 28 04:30:35 2010, RURBAN wrote:

>> Attached patch sanifies this.

> > Thanks, the patch looks reasonable to me. Though it looks like Cwd is > not part of the base Perl installation (at least not in 5.10 and 5.12), > so I think I would have to add that to the list of prerequisites as well.

Cwd is in core since long, it's in PathTools. Recently it moved from cpan to dist. Show quoted text

> Would a simple chdir("/") suffice, or some portable equivalent of that?

Cwd is better :) -- Reini Urban http://phpwiki.org/ http://murbreak.at/

Wed Jul 28 11:52:56 2010 INFINOID [...] cpan.org - Correspondence added

On Wed Jul 28 11:38:54 2010, rurban@x-ray.at wrote: Show quoted text

> Cwd is in core since long, it's in PathTools. Recently it moved from > cpan to dist.

Ok, as long as it's always installed, that works for me. It's in the CPAN module list for 5.8.0, but I didn't see it in the module lists for 5.10.0 or 5.12.0, so I wanted to make sure. Is there somewhere else I should look? Show quoted text

> Cwd is better :)

Agreed. Just want to make sure it's really always available. :)

Thu Jul 29 07:04:00 2010 INFINOID [...] cpan.org - Correspondence added

On Wed Jul 28 04:30:35 2010, RURBAN wrote: Show quoted text

> Attached patch sanifies this.

Patch applied, it will be in the next release. Thanks! http://github.com/Infinoid/svn-bisect/commit/b24b415fc4b5f9bbf6dd608fd4c4ed51ecabdafe

Thu Jul 29 07:04:01 2010 INFINOID [...] cpan.org - Status changed from 'open' to 'patched'

Sun Aug 29 10:01:06 2010 INFINOID [...] cpan.org - Correspondence added

I just uploaded svn-bisect 1.1 to CPAN which contains this fix.

Sun Aug 29 10:01:07 2010 The RT System itself - Status changed from 'patched' to 'open'

Sun Aug 29 10:01:07 2010 INFINOID [...] cpan.org - Status changed from 'open' to 'resolved'