Subject: | Logic error in Makefile.PL prevents building with ExtUtils::MakeMaker < 6.31 |
The `LICENSE' argument of WriteMakefile1 isn't set if
ExtUtils::MakeMaker is older than version 6.31 but the WriteMakefile1
subroutine itself dies if LICENSE isn't present on entry.
Result:
$ perl Makefile.PL INSTALLDIRS=vendor
License not specified at Makefile.PL line 29
If LICENSE had been present, it would have been removed by
WriteMakefile1 prior to calling WriteMakefile.
Attached trivial patch sets all parameters unconditionally and lets
WriteMakefile1 remove entries as designed, fixing the problem.
Subject: | Hook-LexWrap-0.23-Makefile.patch |
--- Hook-LexWrap-0.23/Makefile.PL 2009-11-29 14:33:20.000000000 +0000
+++ Hook-LexWrap-0.23/Makefile.PL 2010-07-27 09:40:44.650010257 +0100
@@ -14,10 +14,8 @@
BUILD_REQUIRES => {
'Test::More' => 0,
},
- ($ExtUtils::MakeMaker::VERSION ge '6.31'?
- ('LICENSE' => 'perl', ) : ()),
- ($ExtUtils::MakeMaker::VERSION ge '6.48'?
- ('MIN_PERL_VERSION' => 5.006,) : ()),
+ 'LICENSE' => 'perl',
+ 'MIN_PERL_VERSION' => 5.006,
clean => { FILES => 'Hook-LexWrap-*' },
);