Bug #59659 for DBIx-Class: quoting bit fields breaks them

Fri Jul 23 11:38:02 2010 RIZEN [...] cpan.org - Ticket created

Subject:

quoting bit fields breaks them

If you create a MySQL table with a field type of 'bit' and then do a query like: $rs->search({ bit_field => 0 }); That will generate SQL like: select * from test where bit_field = ?: '0' However, that will not work, because '0' is not the same as 0. So you'll always get 0 records back. The SQL generated must not quote the 0. select * from test where bit_field = ?: 0

Fri Jul 23 12:43:10 2010 ribasushi [...] leporine.io - Correspondence added

On Fri Jul 23 11:38:02 2010, RIZEN wrote: Show quoted text

> If you create a MySQL table with a field type of 'bit' and then do a > query like: > > $rs->search({ bit_field => 0 }); > > That will generate SQL like: > > select * from test where bit_field = ?: '0' > > However, that will not work, because '0' is not the same as 0. So > you'll always get 0 records > back. The SQL generated must not quote the 0. > > select * from test where bit_field = ?: 0

Quoting is irrelevant to bind variables. The ''s are added by the *STDERR display code* so you can read a string with a traling space e.g. The value being bound is 0, not '0'. Do you have an actual non-working case, or were you just alarmed by the debug output?

Fri Jul 23 12:43:11 2010 The RT System itself - Status changed from 'new' to 'open'

Fri Jul 23 12:56:36 2010 jt [...] plainblack.com - Correspondence added

Subject:	Re: [rt.cpan.org #59659] quoting bit fields breaks them
Date:	Fri, 23 Jul 2010 11:56:23 -0500
To:	bug-DBIx-Class [...] rt.cpan.org
From:	JT Smith <jt [...] plainblack.com>

Show quoted text

> Do you have an actual non-working case, or were you just alarmed by the > debug output?

I have an actual non-working case. Table looks like this: create table user ( id int not null primary key, verified bit not null default 0 ... ); my $inactive_count = $schema->resultset('User')->search( { verified => 0 } )->count; The above always returns 0. As a work around, I've changed the 'verified' field to a tinyint, and everything started working just fine. For my purposes there's no problem changing to a tinyint. I just thought you guys would want to know about this case.

Thu Jan 13 17:50:53 2011 ribasushi [...] leporine.io - Correspondence added

Blocked by lack of functionality as per RT64756

Thu Jan 13 17:50:54 2011 ribasushi [...] leporine.io - Status changed from 'open' to 'stalled'

Thu Jan 13 17:50:54 2011 ribasushi [...] leporine.io - Dependency on ticket #64756 added