Bug #59587 for Dist-Zilla-Plugin-Git: Commit on release not working

Wed Jul 21 01:07:45 2010 xenoterracide [...] gmail.com - Ticket created

Subject:

Commit on release not working

before it seemed by default that if you have changes in dist.ini and Changes they would get committed on a release. now it seems if that's the case they are sent to the releases branch and not kept in the master branch. this seems strange and doesn't work for me. often I'd just bump the version number and update the change log and leave them uncommitted just before release. This would then commit them automagically in a release commit. That doesn't commit to the right branch now.

Wed Jul 21 02:40:44 2010 jquelin [...] cpan.org - Correspondence added

On Wed Jul 21 01:07:45 2010, XENO wrote: Show quoted text

> before it seemed by default that if you have changes in dist.ini and > Changes they would get committed on a release. now it seems if that's the > case they are sent to the releases branch and not kept in the master > branch. this seems strange and doesn't work for me. often I'd just bump > the version number and update the change log and leave them uncommitted > just before release. This would then commit them automagically in a > release commit. That doesn't commit to the right branch now.

hmmm, i guess there's a problem in the plugins ordering. are you using commitbuild plugin? how are the git plugins ordered in your dist.ini?

Wed Jul 21 02:40:45 2010 The RT System itself - Status changed from 'new' to 'open'

Wed Jul 21 02:45:55 2010 xenoterracide [...] gmail.com - Correspondence added

Show quoted text

> hmmm, i guess there's a problem in the plugins ordering. are you using > commitbuild plugin? how are the git plugins ordered in your dist.ini?

... [@Git] push_to = my tag_format = %v [Git::CommitBuild] EOF

Wed Jul 21 03:05:52 2010 jquelin [...] cpan.org - Correspondence added

RT-Send-CC:

yanick [...] babyl.dyndns.org

yanick, i guess there's a problem somewhere in your gitery-fu... maybe it misses a change back to master branch? ==> can you have a look please?

Wed Jul 21 12:46:55 2010 yanick.champoux [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #59587] Commit on release not working
Date:	Wed, 21 Jul 2010 12:46:41 -0400
To:	bug-Dist-Zilla-Plugin-Git [...] rt.cpan.org
From:	Yanick Champoux <yanick.champoux [...] gmail.com>

On July 21, 2010 03:05:53 am you wrote: Show quoted text

> yanick, i guess there's a problem somewhere in your gitery-fu... maybe > it misses a change back to master branch? > ==> can you have a look please?

I'll try to throw an eyeball at it tonight. I think there was one commit of mine that didn't make it to your master. I'll see if that's really the case, and if it's related. Joy, `/anick

Thu Jul 22 22:13:13 2010 yanick [...] babyl.dyndns.org - Correspondence added

Subject:	Re: [rt.cpan.org #59587] Commit on release not working
Date:	Thu, 22 Jul 2010 22:13:30 -0400
To:	bug-Dist-Zilla-Plugin-Git [...] rt.cpan.org
From:	Yanick Champoux <yanick [...] babyl.dyndns.org>

On July 21, 2010 03:05:53 am you wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=59587 > > > yanick, i guess there's a problem somewhere in your gitery-fu... maybe > it misses a change back to master branch?

Yup, I think I have the fix in my master branch. For some reason, 'build_root' becomes invalid at release time (and I'm pretty sure it wasn't doing that before), so I'm simply caching it at build time to re-use later on (look at http://github.com/yanick/dist-zilla-plugin- git/commit/bca6e53bde810f2bf1b0d353ee7b7fac8ab24e95, the code is clearer than I am :-) ). Joy, `/anick

Fri Jul 23 04:46:14 2010 jquelin [...] cpan.org - Correspondence added

thank you yanick. released in 1.102040

Fri Jul 23 04:46:16 2010 jquelin [...] cpan.org - Status changed from 'open' to 'resolved'