Skip Menu |

This queue is for tickets about the DBIx-Class CPAN distribution.

Report information
The Basics
Id: 59565
Status: resolved
Priority: 0/
Queue: DBIx-Class

People
Owner: Nobody in particular
Requestors: sveinns [...] student.matnat.uio.no
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.08123
Fixed in: 0.08124



Subject: TODO tests unexpectedly passed
Just FYI: TODO passed. Test Summary Report ------------------- t/64db.t (Wstat: 0 Tests: 4 Failed: 0) TODO passed: 4 t/multi_create/existing_in_chain.t (Wstat: 0 Tests: 10 Failed: 0) TODO passed: 1-2, 5-6, 10 t/multi_create/reentrance_count.t (Wstat: 0 Tests: 18 Failed: 0) TODO passed: 1-4, 6-10, 12, 15-16, 18 t/prefetch/multiple_hasmany.t (Wstat: 0 Tests: 10 Failed: 0) TODO passed: 2, 6-8 t/prefetch/via_search_related.t (Wstat: 0 Tests: 23 Failed: 0) TODO passed: 21-22 t/row/inflate_result.t (Wstat: 0 Tests: 12 Failed: 0) TODO passed: 3 Files=230, Tests=3813, 120 wallclock secs ( 1.68 usr 0.51 sys + 105.73 cusr 8.36 csys = 116.28 CPU) Result: PASS
On Tue Jul 20 09:06:28 2010, sveinns wrote: Show quoted text
> Just FYI: TODO passed. > > Test Summary Report > ------------------- > t/64db.t (Wstat: 0 Tests: 4
Failed: 0) Show quoted text
> TODO passed: 4 > t/multi_create/existing_in_chain.t (Wstat: 0 Tests: 10 > Failed: 0) > TODO passed: 1-2, 5-6, 10 > t/multi_create/reentrance_count.t (Wstat: 0 Tests: 18 > Failed: 0) > TODO passed: 1-4, 6-10, 12, 15-16, 18 > t/prefetch/multiple_hasmany.t (Wstat: 0 Tests: 10 > Failed: 0) > TODO passed: 2, 6-8 > t/prefetch/via_search_related.t (Wstat: 0 Tests: 23 > Failed: 0) > TODO passed: 21-22 > t/row/inflate_result.t (Wstat: 0 Tests: 12 > Failed: 0) > TODO passed: 3 > Files=230, Tests=3813, 120 wallclock secs ( 1.68 usr 0.51 sys + 105.73 > cusr 8.36 csys = 116.28 CPU) > Result: PASS
Yes there are a couple that can be unmasked now, but in general most of these are in fact failing tests. These are todo blocks which can be considered done only once all tests within them pass.
On Tue Jul 20 09:06:28 2010, sveinns wrote: Show quoted text
> Just FYI: TODO passed. > > Test Summary Report > ------------------- > t/64db.t (Wstat: 0 Tests: 4
Failed: 0) Show quoted text
> TODO passed: 4 > t/multi_create/existing_in_chain.t (Wstat: 0 Tests: 10 > Failed: 0) > TODO passed: 1-2, 5-6, 10 > t/multi_create/reentrance_count.t (Wstat: 0 Tests: 18 > Failed: 0) > TODO passed: 1-4, 6-10, 12, 15-16, 18 > t/prefetch/multiple_hasmany.t (Wstat: 0 Tests: 10 > Failed: 0) > TODO passed: 2, 6-8 > t/prefetch/via_search_related.t (Wstat: 0 Tests: 23 > Failed: 0) > TODO passed: 21-22 > t/row/inflate_result.t (Wstat: 0 Tests: 12 > Failed: 0) > TODO passed: 3 > Files=230, Tests=3813, 120 wallclock secs ( 1.68 usr 0.51 sys + 105.73 > cusr 8.36 csys = 116.28 CPU) > Result: PASS
http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=dbsrgits/DBIx-Class.git;a=commitdiff;h=68eaaf137716f196297285c1d8353deecda5e555 Thank you for bringing this up.