Bug #59247 for Template-Benchmark: Most templates fail on windows

Sat Jul 10 04:27:37 2010 adamk [...] cpan.org - Ticket created

Subject:

Most templates fail on windows

Running the benchmark on Windows, I get "MISMATCHED TEMPLATE OUTPUT" for most of the templates. I suspect it may have something to do with newline types. Should the benchmark ignore newline differences?

Mon Jul 12 05:41:21 2010 SGRAHAM [...] cpan.org - Taken

Mon Jul 12 05:55:20 2010 SGRAHAM [...] cpan.org - Correspondence added

On Sat Jul 10 04:27:37 2010, ADAMK wrote: Show quoted text

> Running the benchmark on Windows, I get "MISMATCHED TEMPLATE OUTPUT" for > most of the templates. > > I suspect it may have something to do with newline types.

This sounds likely, I'm going to have to get a windows install of perl up and running before I can investigate though. About time I investigated strawberry... Show quoted text

> Should the benchmark ignore newline differences?

There's two quick "fixes" that I see and one slower one depending on what the root cause turns out to be. I'll work on making the template output be normalized before comparison, and while I'm at it I'll add an option that lets you bypass the comparison if you think the failure is bogus. That should fix the immediate problem and provide a work-around for people should it crop up in another form in the future. Third fix will be to find out if the difference is in the templates being executed rather than just the output, if so then that will need some tweaking to ensure that like-for-like execution is correct on windows. (Although I doubt it'll impact the results significantly.) I hope that'll address your bug, and please let me know if you think I've missed something obvious in this. I've not used perl on windows in over a decade, so I'm pretty rusty. Thanks for the bug report.

Mon Jul 12 05:55:21 2010 The RT System itself - Status changed from 'new' to 'open'

Mon Jul 12 10:51:03 2010 SGRAHAM [...] cpan.org - Correspondence added

On Mon Jul 12 05:55:20 2010, SGRAHAM wrote: Show quoted text

> I'll work on making the template output be normalized before comparison, > and while I'm at it I'll add an option that lets you bypass the > comparison if you think the failure is bogus.

This is now done in v1.04_01, which should be making its way through CPAN. It also cleans up a few other issues with running on windows. (It shouldn't leave orphaned temporary directories in your root directory any more.) I had some issues getting my tarball to install, probably because I'm not familiar with the install process under windows, so I'm going to have to wait for some windows test reports before I release it as 1.05. You're welcome to download 1.04_01 and see if it fixes your problems though.

Mon Jul 12 10:51:04 2010 SGRAHAM [...] cpan.org - Status changed from 'open' to 'patched'

Mon Jul 12 20:35:58 2010 adam [...] ali.as - Correspondence added

CC:	adamk [...] cpan.org
Subject:	Re: [rt.cpan.org #59247] Most templates fail on windows
Date:	Tue, 13 Jul 2010 10:35:50 +1000
To:	bug-Template-Benchmark [...] rt.cpan.org
From:	Adam Kennedy <adamkennedybackup [...] gmail.com>

pip youtarball.tar.gz On 13 July 2010 00:51, Sam Graham via RT <bug-Template-Benchmark@rt.cpan.org> wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=59247 > > > On Mon Jul 12 05:55:20 2010, SGRAHAM wrote:

>> I'll work on making the template output be normalized before comparison, >> and while I'm at it I'll add an option that lets you bypass the >> comparison if you think the failure is bogus.

> > This is now done in v1.04_01, which should be making its way through CPAN. > > It also cleans up a few other issues with running on windows. > (It shouldn't leave orphaned temporary directories in your root > directory any more.) > > I had some issues getting my tarball to install, probably because I'm > not familiar with the install process under windows, so I'm going to > have to wait for some windows test reports before I release it as 1.05. > > You're welcome to download 1.04_01 and see if it fixes your problems though. >

Mon Jul 12 20:35:58 2010 The RT System itself - Status changed from 'patched' to 'open'

Thu Jul 15 07:45:43 2010 SGRAHAM [...] cpan.org - Correspondence added

On Mon Jul 12 20:35:58 2010, adam@ali.as wrote: Show quoted text

> pip youtarball.tar.gz

Aha, thanks for that. I'm still getting some issues I'm not happy with on windows, but they appear to be different issues to this bug now, so I'm going to mark this report as patched, and move it to resolved once 1.05 is released. Thanks again for the report.

Thu Jul 15 07:45:44 2010 SGRAHAM [...] cpan.org - Status changed from 'open' to 'patched'

Thu Jul 15 07:46:33 2010 SGRAHAM [...] cpan.org - Fixed in 1.04_01 added

Tue Jul 20 16:01:04 2010 SGRAHAM [...] cpan.org - Status changed from 'patched' to 'resolved'

Tue Jul 20 16:01:04 2010 SGRAHAM [...] cpan.org - Fixed in 1.05 added