On Thu, Jul 08, 2010 at 01:41:20AM -0400,
https://launchpad.net/~newacct via RT wrote:
Show quoted text> Thu Jul 08 01:41:19 2010: Request 59194 was acted upon.
> Transaction: Ticket created by
https://launchpad.net/~newacct
> Queue: Term-ReadLine-Perl
> Subject: eval() should be changed to hex() and oct()
> Broken in: 1.0303
> Severity: Unimportant
> Owner: Nobody
> Requestors: spoon.reloaded@gmail.com
> Status: new
> Ticket <URL:
https://rt.cpan.org/Ticket/Display.html?id=59194 >
>
>
> } elsif ($key =~ s#^\\x([0-9a-fA-F]{2})##) {
> push(@keys, eval('0x'.$1));
> } elsif ($key =~ s#^\\([0-7]{3})##) {
> push(@keys, eval('0'.$1));
> should be changed to
> } elsif ($key =~ s#^\\x([0-9a-fA-F]{2})##) {
> push(@keys, hex($1));
> } elsif ($key =~ s#^\\([0-7]{3})##) {
> push(@keys, oct($1));
Agreed.
Show quoted text> because eval is dangerous
No, not in this context. So please send a TESTED patch.
Thanks,
Ilya
