Bug #59030 for DBIx-Class-Schema-Loader: DOS newlines in table comments

Thu Jul 01 12:04:32 2010 KWAKWA [...] cpan.org - Ticket created

I believe this is a problem in all versions. Apologies if I have selected the wrong severity, what's important to me might not be important to you or others. I'm using postgresql 8.1, and a windows based SQL designer. If I have tables comments which have newlines in them, they're added with DOS newlines when the database is generated. This becomes a problem when I dump the schema, and modify the resulting schemas (obviously in the area which is preserved upon any subsequent dumps). If the table comments have a new line and I save the file, the table comments' DOS newlines are replaced with UNIX newlines; this ends up breaking the file as the CHECKSUM recognises the file as being changed. For schemas that I have to edit which have newlines in them, for the time being I'm having to remove the newlines which works, but makes the comments less readable. I believe a option to convert comments to UNIX, or a hook for comments would work nicely. Thank you for your time and effort on this library, it's pretty god damn awesome :)

Thu Jul 01 12:06:41 2010 KWAKWA [...] cpan.org - Status changed from 'new' to 'open'

Thu Jul 01 12:08:07 2010 KWAKWA [...] cpan.org - Subject changed from (no value) to 'DOS newlines in table comments'

Thu Jul 01 12:09:22 2010 KWAKWA [...] cpan.org - Correspondence added

My apologies, I set this to Open by accident.

Wed Jul 07 09:59:14 2010 rkitover@cpan.org - Correspondence added

Subject:	Re: [rt.cpan.org #59030]
Date:	Wed, 7 Jul 2010 09:58:59 -0400
To:	Paul Williams via RT <bug-DBIx-Class-Schema-Loader [...] rt.cpan.org>
From:	Rafael Kitover <rkitover [...] cpan.org>

I think I fixed this, please try: git://git.shadowcat.co.uk/dbsrgits/DBIx-Class-Schema-Loader.git ... Show quoted text

> I'm using postgresql 8.1, and a windows based SQL designer. If I have > tables comments which have newlines in them, they're added with DOS > newlines when the database is generated.

...

Thu Jul 08 05:10:52 2010 KWAKWA [...] cpan.org - Correspondence added

On Wed Jul 07 09:59:14 2010, rkitover@cpan.org wrote: Show quoted text

> I think I fixed this, please try: > > git://git.shadowcat.co.uk/dbsrgits/DBIx-Class-Schema-Loader.git > > ...

> > I'm using postgresql 8.1, and a windows based SQL designer. If I have > > tables comments which have newlines in them, they're added with DOS > > newlines when the database is generated.

> ...

Tested this and it works as expected for table and column comments. Thanks!

Tue Jul 27 17:39:54 2010 rkitover [...] cpan.org - Correspondence added

Fixed in 0.07001 .

Tue Jul 27 17:39:55 2010 rkitover [...] cpan.org - Status changed from 'open' to 'resolved'