Bug #5901 for Apache-Session-Wrapper: _check_sets functionality is plain wrong :(

Tue Mar 30 03:50:46 2004 Guest - Ticket #5835: Ticket created

Subject:

lock_handle should not be required when username, password, etc. is supplied

Logged as requested by Dave Rolsky on mason-users list. The following error is shown in Apache's error log even though appropriate parameters have been set in httpd.conf: Not all of the required parameters for your chosen session class (Apache::Session::MySQL) were provided. Missing the following: handle lock_handle. Example of required params in httpd.conf: PerlAddVar MasonSessionCookieDomain myhost.example.com PerlAddVar MasonSessionClass Apache::Session::MySQL PerlSetVar MasonSessionDataSource dbi:mysql:mydb:127.0.0.1 PerlSetVar MasonSessionUserName user PerlSetVar MasonSessionPassword password PerlSetVar MasonSessionLockDataSource dbi:mysql:mydb:127.0.0.1 PerlSetVar MasonSessionLockUserName user PerlSetVar MasonSessionLockPassword password PerlSetVar MasonSessionUseCookie true PerlSetVar MasonSessionCookieName mycookie

Sat Apr 03 13:34:57 2004 Guest - Ticket created

Subject:

_check_sets functionality is plain wrong :(

IMHO the _check_sets function is inappropriately designed as it tries to find errors for every set instead of trying i.e. to find a set that doesn't spit out any missing items :( My case: using the wrapper with something like this (through MasonX::Request::WithApacheSession): session_class => 'Apache::Session::MySQL', session_use_cookie => 1, session_cookie_name => 'NeoSessID', session_cookie_expires => '+2y', session_cookie_domain => $domain, session_cookie_path => '/', session_cookie_secure => 0, session_cookie_resend => 0, session_param_name => 'SESSID', session_data_source => $r->dir_config('AS_dsn'), session_user_name => $r->dir_config('AS_username'), session_password => $r->dir_config('AS_password'), session_lock_data_source => $r->dir_config('AS_dsn'), session_lock_user_name => $r->dir_config('AS_username'), session_lock_password => $r->dir_config('AS_password'), ... I get the following error: Not all of the required parameters for your chosen session class (Apache::Session::MySQL) were provided. Missing the following: handle lock_handle. As *handle parameters are not required in my setup, and after also reading your comments on %ApacheSessionParams .. I presumed the things above. Until then i just eliminated the second set from ApacheSessionParams->MySQL (perl v5.8.3, Apache::Session::Wrapper v0.13, Linux 2.6.x)

Sat Apr 03 16:50:59 2004 autarch [...] urth.org - Correspondence added

Date:	Sat, 3 Apr 2004 15:50:47 -0600 (CST)
From:	Dave Rolsky <autarch [...] urth.org>
To:	Guest via RT <bug-Apache-Session-Wrapper [...] rt.cpan.org>
Subject:	Re: [cpan #5901] _check_sets functionality is plain wrong :(
RT-Send-Cc:

On Sat, 3 Apr 2004, Guest via RT wrote: Show quoted text

> IMHO the _check_sets function is inappropriately designed as it tries to > find errors for every set instead of trying i.e. to find a set that > doesn't spit out any missing items :(

That's not a design error, that's an implementation error. Either you're giving me too much or too little credit ;) Anyway, this will be fixed in a new release coming soon. -dave /*======================= House Absolute Consulting www.houseabsolute.com =======================*/

Sat Apr 03 16:57:56 2004 DROLSKY [...] cpan.org - Ticket #5835: Ticket 5835 MergedInto ticket 5901.

Sat Apr 03 16:59:16 2004 DROLSKY [...] cpan.org - Correspondence added

This should be fixed in Apache::Session::Wrapper 0.14, which I just uploaded to CPAN. No changes should be necessary to MasonX::Request::WithApacheSession.

Sun Apr 04 11:04:46 2004 DROLSKY [...] cpan.org - Fixed in 0.14 added

Sun Apr 04 11:04:46 2004 DROLSKY [...] cpan.org - Status changed from 'new' to 'resolved'