Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the HTML-FormHandler CPAN distribution.

Report information
The Basics
Id: 58894
Status: resolved
Priority: 0/
Queue: HTML-FormHandler

People
Owner: Nobody in particular
Requestors: KAPPA [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 0.32001
Fixed in: (no value)



Subject: Some tests fail on non-english locale
My locale is ru_RU.UTF-8 and apparently FormHandler now has localized messages for Russian. So a lot of tests fail because they expect English messages. The fix should probably be trivial — just set up "C" locale before running tests.
The tests that check messages have $ENV{LANGUAGE_HANDLE} set to the English messages and so should work OK. I don't see any failures for this in the last bunch of CPAN testers, so I'll need some more details. Which tests fail? Please provide the test output. Thanks.
On Tue Jun 29 09:16:54 2010, GSHANK wrote: Show quoted text
> The tests that check messages have $ENV{LANGUAGE_HANDLE} set to the > English messages and so should work OK. I don't see any failures for > this in the last bunch of CPAN testers, so I'll need some more details. > Which tests fail? Please provide the test output. Thanks.
Please verify FormHandler version. This problem did exist in some previous release, but should not be the case for the most recent.
Втр Июн 29 13:47:13 2010, GSHANK писал: Show quoted text
> On Tue Jun 29 09:16:54 2010, GSHANK wrote:
> > The tests that check messages have $ENV{LANGUAGE_HANDLE} set to the > > English messages and so should work OK. I don't see any failures for > > this in the last bunch of CPAN testers, so I'll need some more
details. Show quoted text
> > Which tests fail? Please provide the test output. Thanks.
> > Please verify FormHandler version. This problem did exist in some > previous release, but should not be the case for the most recent.
Version is 0.32001. Tests that fail are: ------------------- t/dependency.t (Wstat: 1024 Tests: 8 Failed: 4) Failed tests: 4-6, 8 Non-zero exit status: 4 t/form_handler.t (Wstat: 256 Tests: 38 Failed: 1) Failed test: 34 Non-zero exit status: 1 t/result_errors.t (Wstat: 512 Tests: 7 Failed: 2) Failed tests: 6-7 Non-zero exit status: 2 These are relevant parts of build log: cpanm (App::cpanminus) 0.9923 on perl 5.010001 built for i486-linux-gnu- thread-multi Work directory is /home/kappa/.cpanm/work/1277851242.28139 Searching HTML::FormHandler on cpanmetadb ... Fetching http://search.cpan.org/CPAN/authors/id/G/GS/GSHANK/HTML- FormHandler-0.32001.tar.gz ... OK Unpacking HTML-FormHandler-0.32001.tar.gz Entering HTML-FormHandler-0.32001 ... # Failed test 'required field: address' # at t/dependency.t line 49. Wide character in print at /usr/share/perl/5.10/Test/Builder.pm line 1698. # got: 'поле Address является обязательным' # expected: 'Address field is required' # Failed test 'required field: city' # at t/dependency.t line 49. Wide character in print at /usr/share/perl/5.10/Test/Builder.pm line 1698. # got: 'поле City является обязательным' # expected: 'City field is required' ...
Втр Июн 29 09:16:54 2010, GSHANK писал: Show quoted text
> The tests that check messages have $ENV{LANGUAGE_HANDLE} set to the > English messages and so should work OK. I don't see any failures for > this in the last bunch of CPAN testers, so I'll need some more details. > Which tests fail? Please provide the test output. Thanks.
Adding these lines to failing tests indeed solves the problem: use HTML::FormHandler::I18N; $ENV{LANGUAGE_HANDLE} = HTML::FormHandler::I18N->get_handle('en_en');
Thanks. Have fixed the tests in the repo. New release available in the near future.