Skip Menu |

This queue is for tickets about the TAP-Formatter-JUnit CPAN distribution.

Report information
The Basics
Id: 58838
Status: resolved
Priority: 0/
Queue: TAP-Formatter-JUnit

People
Owner: Nobody in particular
Requestors: colin.robertson [...] lovefilm.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 0.08



Subject: Error reporting on die or missing plan
Date: Fri, 25 Jun 2010 18:48:43 +0100
To: bug-TAP-Formatter-JUnit [...] rt.cpan.org
From: Colin Robertson <colin.robertson [...] lovefilm.com>
I'm using TAP::Formatter::JUnit with Hudson and I've run into the issue that Hudson doesn't notice when a test script dies. In that situation T::F::JUnit increments the count in the errors attribute on the testsuite element but it doesn't create an error element in the testsuite, which seems to be what Hudson is looking for. I've attached a patch against 0.07 which creates the error element in this situation and also when there's no plan. Hopefully it's fairly straightforward. My patch includes updated tests as well. Let me know if you have any issues with my code and I'll see what I can do. Cheers. Colin ----------------------------------------------------------------------------------------------------------------------------------------- LOVEFiLM UK Limited is a company registered in England and Wales. Registered Number: 06528297. Registered Office: No.9, 6 Portal Way, London W3 6RU, United Kingdom. This e-mail is confidential to the ordinary user of the e-mail address to which it was addressed. If you have received it in error, please delete it from your system and notify the sender immediately. This email message has been delivered safely and archived online by Mimecast. For more information please visit http://www.mimecast.co.uk -----------------------------------------------------------------------------------------------------------------------------------------

Message body is not shown because sender requested not to inline it.

Many thanks for the patch Colin. I've applied some changes here based on your patch which should address the issues that you were working against... if the test dies or if the plan is missing there's now an "<error>" element in the JUnit. I've run this through a copy of Hudson here locally and it looks fine. Do let me know if this doesn't fix it up for you.