Bug #58325 for List-MoreUtils: apply leaks memory

Thu Jun 10 19:24:01 2010 airwave [...] cpan.org - Ticket created

Subject:

apply leaks memory

The XS implementation of apply leaks memory on perl 5.10.1. Here is a simple loop that you don't want to leave running: use List::MoreUtils qw(apply); while (1) { apply { } (1); }

Thu Oct 14 06:44:11 2010 RANDIR [...] cpan.org - Correspondence added

See patch in the attachment. For those, who'd like to investigate more - i think it's impossible to patch this without introducing second loop either before or after main one, as POP_MULTICALL prevents any attempt to carry mortal'ized vars over it. So, either pre-allocate space or mark as mortal afterward.

Subject:

apply.patch

--- MoreUtils.xs 2006-07-02 19:25:16.000000000 +0400 +++ MoreUtils.xs.new 2010-10-14 14:33:59.000000000 +0400 @@ -603,7 +603,9 @@ } POP_MULTICALL; - done: + for (i = 0; i < items - 1; ++i){ + sv_2mortal(args[i]); + } XSRETURN(items-1); }

Thu Oct 14 06:44:12 2010 The RT System itself - Status changed from 'new' to 'open'

Thu Oct 14 07:04:06 2010 REHSACK [...] cpan.org - Correspondence added

I'll care of it as soon as I find a tuit. Thanks

Sun Dec 05 20:50:08 2010 adamk [...] cpan.org - Correspondence added

I've disabled the XS apply in 0.27_04 until Jens has time to fix it properly.

Fri Mar 21 07:44:27 2014 REHSACK [...] cpan.org - Status changed from 'open' to 'resolved'

Fri Mar 21 07:44:28 2014 REHSACK [...] cpan.org - Fixed in 0.400_004 added