Skip Menu |

This queue is for tickets about the SQL-Translator CPAN distribution.

Report information
The Basics
Id: 58318
Status: resolved
Priority: 0/
Queue: SQL-Translator

People
Owner: Nobody in particular
Requestors: gamid [...] isayev.com
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.11006
Fixed in: 0.11007



Subject: sqlt: quoting options are always on
This issue has been reported before (see RT #27438), but changes made in 0.11003 didn't fix it: - table/field name quoting is on by default - there is no way to turn table/field name quoting off Also, the POD says that options are --quote-table-names and --quote- field-names, but GetOptions() has them defined as --quote_table_names and --quote_field_names ('-' vs '_'). There is proposed patch: --- sqlt 2010-04-30 14:45:44.000000000 -0400 +++ sqlt 2010-06-10 17:07:06.010554000 -0400 @@ -202,8 +202,8 @@ GetOptions( 'add-drop-table' => \$add_drop_table, - 'quote_table_names' => \$quote_table_names, - 'quote_field_names' => \$quote_field_names, + 'quote-table-names' => \$quote_table_names, + 'quote-field-names' => \$quote_field_names, 'd|debug' => \$debug, 'f|from|parser:s' => \$from, 'fs:s' => \$field_separator, @@ -283,8 +283,8 @@ no_comments => $no_comments || 0, show_warnings => $show_warnings || 0, add_drop_table => $add_drop_table || 0, - quote_table_names => defined $quote_table_names ? $quote_table_names : 1, - quote_field_names => defined $quote_field_names ? $quote_field_names : 1, + quote_table_names => defined $quote_table_names ? $quote_table_names : 0, + quote_field_names => defined $quote_field_names ? $quote_field_names : 0, validate => $validate || 0, parser_args => { trim_fields => $no_trim ? 0 : 1,
On Thu Jun 10 17:18:23 2010, https://me.yahoo.com/igamid#b38d2 wrote: Show quoted text
> This issue has been reported before (see RT #27438), but changes made in > 0.11003 didn't fix it: > - table/field name quoting is on by default > - there is no way to turn table/field name quoting off
This is incorrect. All you have to say is: sqlt --quote-table-names 0 Show quoted text
> Also, the POD says that options are --quote-table-names and --quote- > field-names, but GetOptions() has them defined as --quote_table_names > and --quote_field_names ('-' vs '_'). > There is proposed patch:
This part is fixed, thanks for spotting.