Skip Menu |

This queue is for tickets about the POE-Component-Client-HTTP CPAN distribution.

Report information
The Basics
Id: 58265
Status: resolved
Priority: 0/
Queue: POE-Component-Client-HTTP
People
Owner: Nobody in particular
Requestors: johan [...] headweb.com
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Wed Jun 09 04:58:01 2010 johan [...] headweb.com - Ticket created
Subject: POE::Component::Client::HTTP spurious warnings with SSLify
Date: Wed, 9 Jun 2010 10:57:48 +0200
To: bug-POE-Component-Client-HTTP [...] rt.cpan.org
From: Johan Ström <johan [...] headweb.com>
POE/Component/Client/HTTP.pm line 344 my $peer_addr = getpeername($new_wheel->get_input_handle()); getpeername is not valid on a SSLifyed socket; it yields getpeername() on unopened socket GEN46 at /usr/lib/perl5/site_perl/ 5.8.8/POE/Component/Client/HTTP.pm line 344. See http://search.cpan.org/dist/POE-Component-SSLify/lib/POE/Component/SSLify.pm#Socket_methods_doesn%27t_work
  Fri Jul 23 13:16:23 2010 yikes2000 [...] yahoo.com - Correspondence added
From: yikes2000 [...] yahoo.com
This patch should fix it... --- HTTP.pm.orig 2010-02-14 22:19:05.000000000 -0800 +++ HTTP.pm 2010-07-23 08:39:16.000000000 -0700 @@ -18,6 +18,7 @@ use POE::Component::Client::HTTP::RequestFactory; use POE::Component::Client::HTTP::Request qw(:states :fields); +use POE::Component::SSLify qw( SSLify_GetSocket ); BEGIN { local $SIG{'__DIE__'} = 'DEFAULT'; @@ -341,7 +342,10 @@ $request->[REQ_CONNECTION] = $connection; - my $peer_addr = getpeername($new_wheel->get_input_handle()); + #my $peer_addr = getpeername($new_wheel->get_input_handle()); + my $socket = $new_wheel->get_input_handle(); + my $peer_addr = $request->scheme ne 'https' ? getpeername($socket) : + getpeername( SSLify_GetSocket($socket) ); if (defined $peer_addr) { my ($port, $iaddr) = sockaddr_in($peer_addr); $request->[REQ_PEERNAME] = inet_ntoa($iaddr) . "." . $port;
Subject: HTTP.pm.diff
--- HTTP.pm.orig 2010-02-14 22:19:05.000000000 -0800 +++ HTTP.pm 2010-07-23 08:39:16.000000000 -0700 @@ -18,6 +18,7 @@ use POE::Component::Client::HTTP::RequestFactory; use POE::Component::Client::HTTP::Request qw(:states :fields); +use POE::Component::SSLify qw( SSLify_GetSocket ); BEGIN { local $SIG{'__DIE__'} = 'DEFAULT'; @@ -341,7 +342,10 @@ $request->[REQ_CONNECTION] = $connection; - my $peer_addr = getpeername($new_wheel->get_input_handle()); + #my $peer_addr = getpeername($new_wheel->get_input_handle()); + my $socket = $new_wheel->get_input_handle(); + my $peer_addr = $request->scheme ne 'https' ? getpeername($socket) : + getpeername( SSLify_GetSocket($socket) ); if (defined $peer_addr) { my ($port, $iaddr) = sockaddr_in($peer_addr); $request->[REQ_PEERNAME] = inet_ntoa($iaddr) . "." . $port;
  Fri Jul 23 13:16:25 2010 The RT System itself - Status changed from 'new' to 'open'
  Wed Jan 26 18:28:40 2011 APOCAL [...] cpan.org - Dependency by ticket #64741 added
  Wed Jan 26 18:48:18 2011 APOCAL [...] cpan.org - Dependency by ticket #59846 added
  Wed Jan 26 18:53:39 2011 APOCAL [...] cpan.org - Correspondence added
Thanks very much for the report! Thanks even *MORE* for the patch :) It should be resolved in the next release, which I expect to be soon. -- ~Apocalypse
  Wed Jan 26 23:26:47 2011 RCAPUTO [...] cpan.org - Correspondence added
Patch applied, thanks!
  Wed Jan 26 23:26:48 2011 RCAPUTO [...] cpan.org - Status changed from 'open' to 'resolved'