Skip Menu |

This queue is for tickets about the Params-Validate CPAN distribution.

Report information
The Basics
Id: 58087
Status: resolved
Priority: 0/
Queue: Params-Validate
People
Owner: Nobody in particular
Requestors: RASSIE [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: Important
Broken in: 0.95
Fixed in: 0.97

History Show all quoted text
  Thu Jun 03 08:06:48 2010 RASSIE [...] cpan.org - Ticket created
Subject: Needs localization of $@ Validate.pm
Currently, Param::Validate's BEGIN block is using an eval block without localizing $@. Therefore, if Params::Validate is somehow used in a DESTROY sub, multi-level exception handling will fail. I can probably provide a minimal example for that, but not before Monday. Related links: http://stackoverflow.com/questions/2949622/is-evaling-in-a-cpan-module- without-localizing-a-bug (my question about filing this bug report) http://search.cpan.org/dist/Perl- Critic/lib/Perl/Critic/Policy/ErrorHandling/RequireCheckingReturnValueO fEval.pm Apparently, the recommendation to localize $@ only appears in the german $foo magazine, so I can't give you a link to that.
  Thu Jun 03 09:06:21 2010 autarch [...] urth.org - Correspondence added
Subject: Re: [rt.cpan.org #58087] Needs localization of $@ Validate.pm
Date: Thu, 3 Jun 2010 08:05:45 -0500 (CDT)
To: "Ник棗爭檳僥\xDB Прок棗爭螂屶澁樛о via RT" <bug-Params-Validate [...] rt.cpan.org>
From: Dave Rolsky <autarch [...] urth.org>
On Thu, 3 Jun 2010, Николай Прокошенко via RT wrote: Show quoted text
> Currently, Param::Validate's BEGIN block is using an eval block without > localizing $@. Therefore, if Params::Validate is somehow used in a > DESTROY sub, multi-level exception handling will fail. > > I can probably provide a minimal example for that, but not before > Monday.
A patch with tests would be welcome. Even just a test would be welcome. -dave /*============================================================ http://VegGuide.org http://blog.urth.org Your guide to all that's veg House Absolute(ly Pointless) ============================================================*/
  Thu Jun 03 09:06:23 2010 The RT System itself - Status changed from 'new' to 'open'
  Wed Apr 20 20:59:08 2011 DROLSKY [...] cpan.org - Status changed from 'open' to 'resolved'
  Wed Apr 20 20:59:08 2011 DROLSKY [...] cpan.org - Fixed in 0.97 added