Bug #57956 for Date-Calc: Incorrect dates in bundled Canadian date profiles

Fri May 28 15:31:05 2010 itguy69 [...] gmail.com - Ticket created

Subject:

Incorrect dates in bundled Canadian date profiles

In the built-in date profiles (in Profiles.pm) for Canada (CA), the calculation for the holiday "Victoria Day" is incorrect. Currently it's set to always be the 22nd of May, but it should actually be on the last Monday on or before the 24th of May. I noticed a sub called "CA_QC_Dollard" that calculates "Fête de Dollard" for Quebec, and it seems to work correctly as this holiday falls on the same day as "Victoria Day". I think this function could be used to calculate all the occurrences of "Victoria Day" correctly with a minimal amount of effort.

Sat Mar 07 11:48:04 2015 STBEY [...] cpan.org - Correspondence added

On Fri May 28 15:31:05 2010, the_doctor wrote: Show quoted text

> In the built-in date profiles (in Profiles.pm) for Canada (CA), the > calculation for the holiday "Victoria Day" is incorrect. Currently it's > set to always be the 22nd of May, but it should actually be on the last > Monday on or before the 24th of May. > > I noticed a sub called "CA_QC_Dollard" that calculates "Fête de Dollard" > for Quebec, and it seems to work correctly as this holiday falls on the > same day as "Victoria Day". I think this function could be used to > calculate all the occurrences of "Victoria Day" correctly with a minimal > amount of effort.

I intend not to make any fixes to any of the calendar profiles anymore unless there are VERY compelling reasons to do so. These profiles are merely meant as examples. The suggested way of using these profiles is to copy them to one's own code and then to modify them as needed. (Otherwise many people could be negatively affected if I made any changes to a profile they are using) Any improvements such as the one suggested by you are therefore left as an exercise to the inclined reader. :-)

Sat Mar 07 11:48:04 2015 The RT System itself - Status changed from 'new' to 'open'

Sat Mar 07 14:27:02 2015 SREZIC [...] cpan.org - Correspondence added

On 2015-03-07 11:48:04, STBEY wrote: Show quoted text

> On Fri May 28 15:31:05 2010, the_doctor wrote:

> > In the built-in date profiles (in Profiles.pm) for Canada (CA), the > > calculation for the holiday "Victoria Day" is incorrect. Currently > > it's > > set to always be the 22nd of May, but it should actually be on the > > last > > Monday on or before the 24th of May. > > > > I noticed a sub called "CA_QC_Dollard" that calculates "Fête de > > Dollard" > > for Quebec, and it seems to work correctly as this holiday falls on > > the > > same day as "Victoria Day". I think this function could be used to > > calculate all the occurrences of "Victoria Day" correctly with a > > minimal > > amount of effort.

> > > I intend not to make any fixes to any of the calendar profiles anymore > unless there are VERY compelling reasons to do so. > These profiles are merely meant as examples. > The suggested way of using these profiles is to copy them to one's own > code and then to modify them as needed. > (Otherwise many people could be negatively affected if I made any > changes to a profile they are using) > Any improvements such as the one suggested by you are therefore left > as an exercise to the inclined reader. :-)

This statement contradicts this sentence in the preface section of the Profiles.pm Pod: "Please let me know of any errors in these profiles ..." <https://metacpan.org/pod/distribution/Date-Calc/lib/Date/Calendar/Profiles.pod#PREFACE> Regards, Slaven

Sat Mar 07 14:34:27 2015 STBEY [...] cpan.org - Correspondence added

On Sat Mar 07 14:27:02 2015, SREZIC wrote: Show quoted text

> On 2015-03-07 11:48:04, STBEY wrote:

> > On Fri May 28 15:31:05 2010, the_doctor wrote:

> > > In the built-in date profiles (in Profiles.pm) for Canada (CA), the > > > calculation for the holiday "Victoria Day" is incorrect. Currently > > > it's > > > set to always be the 22nd of May, but it should actually be on the > > > last > > > Monday on or before the 24th of May. > > > > > > I noticed a sub called "CA_QC_Dollard" that calculates "Fête de > > > Dollard" > > > for Quebec, and it seems to work correctly as this holiday falls on > > > the > > > same day as "Victoria Day". I think this function could be used to > > > calculate all the occurrences of "Victoria Day" correctly with a > > > minimal > > > amount of effort.

> > > > > > I intend not to make any fixes to any of the calendar profiles > > anymore > > unless there are VERY compelling reasons to do so. > > These profiles are merely meant as examples. > > The suggested way of using these profiles is to copy them to one's > > own > > code and then to modify them as needed. > > (Otherwise many people could be negatively affected if I made any > > changes to a profile they are using) > > Any improvements such as the one suggested by you are therefore left > > as an exercise to the inclined reader. :-)

> > This statement contradicts this sentence in the preface section of the > Profiles.pm Pod: "Please let me know of any errors in these profiles > ..." <https://metacpan.org/pod/distribution/Date- > Calc/lib/Date/Calendar/Profiles.pod#PREFACE> > > Regards, > Slaven

You are correct, this is a contradiction. I will remove that statement. :-)