Skip Menu |

This queue is for tickets about the Dist-Zilla-Plugin-Git CPAN distribution.

Report information
The Basics
Id: 57915
Status: open
Priority: 0/
Queue: Dist-Zilla-Plugin-Git
People
Owner: Nobody in particular
Requestors: xenoterracide [...] gmail.com
Cc:
AdminCc:
Bug Information
Severity: Wishlist
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Thu May 27 19:40:02 2010 xenoterracide [...] gmail.com - Ticket created
Subject: CommitBuild after successful test
I don't really want CommitBuild to commit anytime I build. However after a successful passing of dzil test would be ok, or maybe after a successful test if and only if the branch the build is based on has a newer commit.
  Fri May 28 05:13:53 2010 jquelin [...] cpan.org - Correspondence added
RT-Send-CC: bphillips [...] digitalriver.com
On Thu May 27 19:40:02 2010, XENO wrote: Show quoted text
> I don't really want CommitBuild to commit anytime I build. However after > a successful passing of dzil test would be ok, or maybe after a > successful test if and only if the branch the build is based on has a > newer commit.
i'm not a big fan of commitbuild either, which is why i did not put this plugin as part of @git. in fact, it has been contributed by brian (that i added in cc:), i just merged the results. ==> brian, what do you think of xeno's ideas? i think that detecting whether there's a newer commit is a sensible idea. i'm less sure regarding needing tests to pass: one may not want to run a long test suite, or maybe needs help regarding failing tests... so, can you guys brainstorm about a sensible behaviour? if the needs are really different, it's also possible to rename commitbuild to sthg else (commitbuildtree or whatever), with a parameter specifying when the commit should happen, after build or after test. in any cases, i'm welcoming any pull requests, so don't hesitate to code it your way. code is available at github.com/jquelin/dist-zilla-plugin-git note that since i'm not that much interested in this plugin, i'm just making sure tests pass for it, but don't concentrate that much on evolving its features. i'd rather merging pullreqs. :-)
  Fri May 28 05:13:54 2010 The RT System itself - Status changed from 'new' to 'open'
  Wed Jun 02 12:34:01 2010 bpphillips+bitcard [...] gmail.com - Correspondence added
On Fri May 28 05:13:53 2010, JQUELIN wrote: Show quoted text
> ==> brian, what do you think of xeno's ideas?
I just hacked the original together as fun exercise so if people want it to behave differently, by all means, it can be changed. It looks like yanick changed things around to do something a bit more sophisticated on github, perhaps that should be pulled in at some point: http://github.com/yanick/dist-zilla-plugin-git/tree/parent_source
  Tue Jun 29 13:04:43 2010 jquelin [...] cpan.org - Correspondence added
Show quoted text
> It looks like yanick changed things around to do something a bit more > sophisticated on github, perhaps that should be pulled in at some point: > http://github.com/yanick/dist-zilla-plugin-git/tree/parent_source
i merged yanick's tree, which allows one to commit after a release. ==> does that suits your need? if yes, can you close this ticket please?
  Wed Jul 21 01:00:31 2010 xenoterracide [...] gmail.com - Correspondence added
RT-Send-CC: xenoterracide [...] gmail.com
Show quoted text
> i merged yanick's tree, which allows one to commit after a release. > ==> does that suits your need?
sorry for not replying soon. Oh RT how much I hate thee, for not emailing me of replies. not really. I can see the people who want every build and those who want every release only. only after a commit probably wouldn't work because commit build uses the build. I asked RJBS a while ago for an AfterTest hook. Don't know if anything came of that. I realize that some people wouldn't want AfterTest but I run my test suite after every change of code. If it doesn't pass I see no reason to have my broken crap committed on another branch.
  Wed Feb 02 04:29:59 2011 jquelin [...] cpan.org - Correspondence added
On Wed Jul 21 01:00:31 2010, XENO wrote: Show quoted text
> I asked RJBS a while ago for an AfterTest hook. Don't know if anything > came of that.
any news on this topic?
  Wed Feb 02 04:35:55 2011 xenoterracide [...] gmail.com - Correspondence added
Subject: Re: [rt.cpan.org #57915] CommitBuild after successful test
Date: Wed, 2 Feb 2011 03:35:47 -0600
To: bug-Dist-Zilla-Plugin-Git [...] rt.cpan.org
From: Caleb Cushing <xenoterracide [...] gmail.com>
On Wed, Feb 2, 2011 at 3:30 AM, Jerome Quelin via RT <bug-Dist-Zilla-Plugin-Git@rt.cpan.org> wrote: Show quoted text
> any news on this topic? >
what news are you looking for? I don't see any questions pending. -- Caleb Cushing http://xenoterracide.com
  Thu Feb 03 08:10:02 2011 jquelin [...] cpan.org - Correspondence added
On Wed Feb 02 04:35:55 2011, XENO wrote: Show quoted text
> On Wed, Feb 2, 2011 at 3:30 AM, Jerome Quelin via RT > <bug-Dist-Zilla-Plugin-Git@rt.cpan.org> wrote:
> > any news on this topic?
> > what news are you looking for? I don't see any questions pending.
whether there'll be an aftertest role in dzil.
  Thu Feb 03 23:08:44 2011 xenoterracide [...] gmail.com - Correspondence added
Subject: Re: [rt.cpan.org #57915] CommitBuild after successful test
Date: Thu, 3 Feb 2011 22:04:53 -0600
To: bug-Dist-Zilla-Plugin-Git [...] rt.cpan.org
From: Caleb Cushing <xenoterracide [...] gmail.com>
On Thu, Feb 3, 2011 at 7:10 AM, Jerome Quelin via RT <bug-Dist-Zilla-Plugin-Git@rt.cpan.org> wrote: Show quoted text
> whether there'll be an aftertest role in dzil. >
nope, I don't think rjbs ever said, though I think he said he hates the whole beforeX afterX thing... -- Caleb Cushing http://xenoterracide.com