Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Git-Wrapper CPAN distribution.

Report information
The Basics
Id: 57311
Status: resolved
Priority: 0/
Queue: Git-Wrapper

People
Owner: GENEHACK [...] cpan.org
Requestors: MITHALDU [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Critical
Broken in: 0.008
Fixed in: (no value)



Subject: date test fails on windows due to strftime being unreliable
On Windows strftime cannot display the timezone offset, but only the TZ name or abbreviation: http://msdn.microsoft.com/de-de/library/fe06s4ak (VS.80).aspx This makes the date test fail due to unexpected value-checking data. Suggested fix: Change: my $date = strftime("%Y-%m-%d %H:%M:%S %z", localtime($time)); to: my $date = strftime("%Y-%m-%d %H:%M:%S", localtime($time)); Add: my $log_date = $log->date; $log_date =~ s/ [+-]\d+$//; Change: is($log_date, $date, "date"); to: is($log_date, $date, "date");
On Sat May 08 22:48:34 2010, MITHALDU wrote: Show quoted text
> On Windows strftime cannot display the timezone offset, but only the TZ > name or abbreviation: http://msdn.microsoft.com/de-de/library/fe06s4ak > (VS.80).aspx > > This makes the date test fail due to unexpected value-checking data. > > Suggested fix: > > Change: > my $date = strftime("%Y-%m-%d %H:%M:%S %z", localtime($time)); > to: > my $date = strftime("%Y-%m-%d %H:%M:%S", localtime($time)); > > Add: > my $log_date = $log->date; > $log_date =~ s/ [+-]\d+$//; > > Change: > is($log_date, $date, "date"); > to: > is($log_date, $date, "date"); >
It looks like this fix went in around version 0.010 -- closing this ticket. thanks, john.