Skip Menu |

This queue is for tickets about the DBM-Deep CPAN distribution.

Report information
The Basics
Id: 57283
Status: resolved
Priority: 0/
Queue: DBM-Deep
People
Owner: Nobody in particular
Requestors: ansgar [...] 43-1.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Fri May 07 13:19:26 2010 ansgar [...] 43-1.org - Ticket created
Subject: [PATCH] Test failure with perl 5.12
Date: Sat, 08 May 2010 02:18:48 +0900
To: bug-DBM-Deep [...] rt.cpan.org
From: Ansgar Burchardt <ansgar [...] 43-1.org>
Hi, the tests fail with perl 5.12 [1] due to a new warning: t/01_basic.t .................... ok Use of uninitialized value $_ in lc at /build/niko-libdbm-deep-perl_1.0022-1-i386-4RBZoH/libdbm-deep-perl- 1.0022/blib/lib/DBM/Deep/Storage/DBI.pm line 60. # Tests were run but no plan was declared and done_testing() was not seen. t/02_hash.t ..................... Dubious, test returned 255 (wstat 65280, 0xff00) All 50 subtests passed [...] Note that we use TEST_SQLITE=1 to enable the additional tests. I prepared a small patch to avoid this warning. DBM::Deep passes the test suite with perl 5.10.1 and 5.12 on Debian with this patch. Please consider applying it for the next release. Regards, Ansgar [1] <http://bugs.debian.org/580189>
From: Ansgar Burchardt <ansgar@43-1.org> Date: Sat, 08 May 2010 01:44:05 +0900 Bug-Debian: http://bugs.debian.org/580189 Subject: Fix build with perl 5.12 This fixes the following warnings: Use of uninitialized value $_ in lc at .../lib/DBM/Deep/Storage/DBI.pm line 60. --- libdbm-deep-perl.orig/lib/DBM/Deep/Storage/DBI.pm +++ libdbm-deep-perl/lib/DBM/Deep/Storage/DBI.pm @@ -57,7 +57,7 @@ ) or die $DBI::error; # Should we use the same method as done in new() if passed a $dbh? - (undef, $self->{driver}) = map lc, DBI->parse_dsn( $self->{dbi}{dsn} ); + (undef, $self->{driver}) = map defined($_) ? lc($_) : undef, DBI->parse_dsn( $self->{dbi}{dsn} ); return 1; }
  Sun May 09 16:03:04 2010 $_ = 'spro^^*%*^6ut# [...] &$%*c>#!^!#&!pan.org'; y/a-z.@//cd; print - Correspondence added
On Fri May 07 13:19:26 2010, ansgar@43-1.org wrote: Show quoted text
> I prepared a small patch to avoid this warning. DBM::Deep passes the > test suite with perl 5.10.1 and 5.12 on Debian with this patch. > Please consider applying it for the next release. >
Thank you. I’ve applied it and plan to make a release within the next few hours.
  Sun May 09 16:03:06 2010 The RT System itself - Status changed from 'new' to 'open'
  Sun May 09 16:09:16 2010 $_ = 'spro^^*%*^6ut# [...] &$%*c>#!^!#&!pan.org'; y/a-z.@//cd; print - Status changed from 'open' to 'resolved'
  Sun May 09 17:52:34 2010 $_ = 'spro^^*%*^6ut# [...] &$%*c>#!^!#&!pan.org'; y/a-z.@//cd; print - Correspondence added
On Sun May 09 16:03:04 2010, SPROUT wrote: Show quoted text
> On Fri May 07 13:19:26 2010, ansgar@43-1.org wrote:
> > I prepared a small patch to avoid this warning. DBM::Deep passes
> the
> > test suite with perl 5.10.1 and 5.12 on Debian with this patch. > > Please consider applying it for the next release. > >
> Thank you. I’ve applied it and plan to make a release within the next > few hours.
I forgot to mention that it is fixed in 1.0023. Unfortunately RT won’t let me choose that until days after a release when I can no longer remember to do so. :-(
  Sun May 09 17:52:35 2010 The RT System itself - Status changed from 'resolved' to 'open'
  Sun May 09 17:52:52 2010 $_ = 'spro^^*%*^6ut# [...] &$%*c>#!^!#&!pan.org'; y/a-z.@//cd; print - Status changed from 'open' to 'resolved'