Bug #57245 for DBIx-Class-Schema-Loader: Provide ability to make "date" db data types "datetime" dbic types

Thu May 06 00:52:19 2010 dhorne [...] cpan.org - Ticket created

Subject:

Provide ability to make "date" db data types "datetime" dbic types

My main development for a project is against Oracle, but the app itself can be deployed to other database products. Oracle's "date" data type caters for dates and dates + time. However, other databases make a distinction. I'd like a flag that will allow the generation of packages to use "datetime" types when generating for a date type. At the moment I manually make the change, but a regeneration means this change is lost. Thanks

Thu May 06 17:01:55 2010 rkitover@cpan.org - Correspondence added

Subject:	Re: [rt.cpan.org #57245] Provide ability to make "date" db data types "datetime" dbic types
Date:	Thu, 6 May 2010 17:01:29 -0400
To:	Dan Horne via RT <bug-DBIx-Class-Schema-Loader [...] rt.cpan.org>
From:	Rafael Kitover <rkitover [...] cpan.org>

On Thu, May 06, 2010 at 12:52:20AM -0400, Dan Horne via RT wrote: Show quoted text

> My main development for a project is against Oracle, but the app itself > can be deployed to other database products. > > Oracle's "date" data type caters for dates and dates + time. However, > other databases make a distinction. I'd like a flag that will allow the > generation of packages to use "datetime" types when generating for a > date type. At the moment I manually make the change, but a regeneration > means this change is lost. > > Thanks

In git at: git://git.shadowcat.co.uk/dbsrgits/DBIx-Class-Schema-Loader.git I've implemented the "date" to "datetime" rewriting, as well as \"sysdate" to \"current_timestamp" rewriting. Also, the type info for Oracle is much improved, so it should be easier to ->deploy and cross-deploy to other DBs. Please try it out and let me know how it works for you.

Thu May 06 17:01:59 2010 The RT System itself - Status changed from 'new' to 'open'

Mon May 10 22:00:52 2010 dan.horne [...] redbone.co.nz - Correspondence added

Subject:	Re: [rt.cpan.org #57245] Provide ability to make "date" db data types "datetime" dbic types
Date:	Tue, 11 May 2010 14:00:28 +1200
To:	bug-DBIx-Class-Schema-Loader [...] rt.cpan.org
From:	Dan Horne <dan.horne [...] redbone.co.nz>

Hi Thanks for working on this. Unfortunately, my tests against the original db (Oracle) fail because the unique constraint names are now in upper case, and my code uses the lower case names - e.g.: my $config = $self->EtlpConfiguration->find_or_create( { config_name => $self->name, date_created => $now, date_updated => $now }, {key => 'etlp_configuration_u1'} # fails here ); regards Dan On 7 May 2010 09:01, rkitover@cpan.org via RT < bug-DBIx-Class-Schema-Loader@rt.cpan.org> wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=57245 > > > On Thu, May 06, 2010 at 12:52:20AM -0400, Dan Horne via RT wrote:

> > My main development for a project is against Oracle, but the app itself > > can be deployed to other database products. > > > > Oracle's "date" data type caters for dates and dates + time. However, > > other databases make a distinction. I'd like a flag that will allow the > > generation of packages to use "datetime" types when generating for a > > date type. At the moment I manually make the change, but a regeneration > > means this change is lost. > > > > Thanks

> > In git at: > git://git.shadowcat.co.uk/dbsrgits/DBIx-Class-Schema-Loader.git > > I've implemented the "date" to "datetime" rewriting, as well as > \"sysdate" to \"current_timestamp" rewriting. > > Also, the type info for Oracle is much improved, so it should be easier > to ->deploy and cross-deploy to other DBs. > > Please try it out and let me know how it works for you. > >

Mon May 10 22:58:00 2010 rkitover@cpan.org - Correspondence added

Subject:	Re: [rt.cpan.org #57245] Provide ability to make "date" db data types "datetime" dbic types
Date:	Mon, 10 May 2010 22:57:34 -0400
To:	"dan.horne [...] redbone.co.nz via RT" <bug-DBIx-Class-Schema-Loader [...] rt.cpan.org>
From:	Rafael Kitover <rkitover [...] cpan.org>

Sorry about that, I was working on a case-preserving mode for people with mixed-case quoted DDL (I think there are not a lot of these people, but it does happen.) Just pushed a fix, hopefully. On Mon, May 10, 2010 at 10:00:55PM -0400, dan.horne@redbone.co.nz via RT wrote: Show quoted text

> Queue: DBIx-Class-Schema-Loader > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=57245 > > > Hi > > Thanks for working on this. Unfortunately, my tests against the original db > (Oracle) fail because the unique constraint names are now in upper case, and > my code uses the lower case names - e.g.: > > my $config = $self->EtlpConfiguration->find_or_create( > { > config_name => $self->name, > date_created => $now, > date_updated => $now > > }, > > {key => 'etlp_configuration_u1'} # fails here > ); > > regards > > Dan

Wed May 12 00:29:26 2010 dhorne [...] cpan.org - Correspondence added

On Mon May 10 22:58:00 2010, rkitover wrote: Show quoted text

> Sorry about that, I was working on a case-preserving mode for people > with mixed-case quoted DDL (I think there are not a lot of these > people, > but it does happen.) > > Just pushed a fix, hopefully. >

No worries. This works for me. Thanks Dan

Mon May 24 03:08:01 2010 rkitover [...] cpan.org - Correspondence added

Added in 0.07000 .

Mon May 24 03:08:02 2010 rkitover [...] cpan.org - Status changed from 'open' to 'resolved'