Skip Menu |

This queue is for tickets about the CGI-CRUD CPAN distribution.

Report information
The Basics
Id: 57082
Status: open
Priority: 0/
Queue: CGI-CRUD

People
Owner: Nobody in particular
Requestors: PJNEWMAN [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Unimportant
Broken in: 1.05
Fixed in: (no value)



Subject: Broken SQL when no config entered into DB
When there isn't any table data in the config table, it generates broken SQL and dies. This fixes that bug, although it might be nice to show all fields if nothing at all has been configured. 262a263,264 Show quoted text
> #Don't generate duff SQL and die > if (defined($ffield)) {
263a266 Show quoted text
> }
Not sure how this patch is applied, or perhaps it has already been fixed in the most recent version? Feel free to re-open with more details. Thanks, -Reed
Heh, had me scratching my head a bit, I don't know why I didn't add more info in the first place. I'm pretty certain it's CGI/CRUD/TableIO.pm, as that seems to be the only file with $ffield in it. However I've just tried deleting all the config in ui_table_column and it's not throwing errors this time, so I'm not entirely sure what I was talking about. However changing line 267 (in the latest TableIO.pm), to "$searcher- Show quoted text
>sortlist([ undef ]);", which is effectively what my patch was trying
to mitigate against, does indeed cause it to error, from the looks of things because it tries to sort by just the table name. So I can't remember/reproduce the exact circumstances that caused me to log the bug, but at least in the version I'm running, it does fix some edge case I reached somehow in the past. On Tue Jun 05 21:18:07 2012, RSANDBERG wrote: Show quoted text
> Not sure how this patch is applied, or perhaps it has already been
fixed Show quoted text
> in the most recent version? Feel free to re-open with more details. > Thanks, > -Reed