Skip Menu |

This queue is for tickets about the local-lib CPAN distribution.

Report information
The Basics
Id: 57049
Status: rejected
Priority: 0/
Queue: local-lib

People
Owner: Nobody in particular
Requestors: dekimsey [...] at.ufl.edu
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: the install action defined in modulebuildrc is too specific.
Module::Build's modulebuildrc file uses the given action to define the scope of a setting. Setting the install_base parameter for the install action prevents the use of the command-line option during the initial Build. It is probably a better idea to use the psuedo-action Build_PL instead. (https://rt.cpan.org/Public/Bug/Display.html?id=57043#txn-770021) Patch attached changes the modulebuildrc template. Note, at the moment this does not yet work as M::B appears to have a bug where it will ignore parameters specified from the command-line in preference to those provided through the rc file. See: https://rt.cpan.org/Public/Bug/Display.html?id=57043
Subject: modulebuildrc-action.patch
diff -ru local-lib-1.006000/lib/local/lib.pm patched-1.006000/lib/local/lib.pm --- local-lib-1.006000/lib/local/lib.pm 2010-03-31 14:12:22.000000000 -0400 +++ patched-1.006000/lib/local/lib.pm 2010-04-29 14:07:15.000000000 -0400 @@ -237,7 +237,7 @@ warn "Attempting to create file ${modulebuildrc_path}\n"; open MODULEBUILDRC, '>', $modulebuildrc_path || Carp::croak("Couldn't open ${modulebuildrc_path} for writing: $!"); - print MODULEBUILDRC qq{install --install_base ${path}\n} + print MODULEBUILDRC qq{Build_PL --install_base ${path}\n} || Carp::croak("Couldn't write line to ${modulebuildrc_path}: $!"); close MODULEBUILDRC || Carp::croak("Couldn't close file ${modulebuildrc_path}: $@");
On Thu Apr 29 14:12:22 2010, http://dekimsey.myopenid.com/ wrote: Show quoted text
> Note, at the moment this does not yet work as M::B appears to have a > bug where it > will ignore parameters specified from the command-line in preference > to those > provided through the rc file. > See: https://rt.cpan.org/Public/Bug/Display.html?id=57043 >
I do not believe this is reported issue with M::B is actually a bug. I made a mistake during the testing. I've requested it be closed on M::B. However, the prior comment about changing the specificity of the install_base parameter still applies.
I concur. Build_PL should be preferred for setting things like install_base. Otherwise A) it cannot be overridden (possible MB misfeature, see https://rt.cpan.org/Ticket/Display.html?id=57043) and B) it will not apply to other targets like fakeinstall (see https://rt.cpan.org/Ticket/Display.html?id=57279)
Invalid now that we're using PERL_MB_OPT.