| Subject: | [PATCH] Catalyst::Response documentation - warn about relative URLs. |
This patch adds the following paragraph to $res->redirect( $url, $status ):
[quote]
B<Note:> do not give a relative URL as $url, i.e: one that is not fully
qualified (= C<http://...>, etc.) or that starts with a slash
(= C</path/here>). While it may work, it is not guaranteed to do the right
thing and is not a standard behaviour. You may opt to use uri_for() or
uri_for_action() instead.
[/quote]
Please apply it.
Regards,
-- Shlomi Fish
| Subject: | Catalyst-Response-doc-patch.diff |
Index: lib/Catalyst/Response.pm
===================================================================
--- lib/Catalyst/Response.pm (revision 13187)
+++ lib/Catalyst/Response.pm (working copy)
@@ -153,6 +153,12 @@
want to C< return > or C<< $c->detach() >> to interrupt the normal
processing flow if you want the redirect to occur straight away.
+B<Note:> do not give a relative URL as $url, i.e: one that is not fully
+qualified (= C<http://...>, etc.) or that starts with a slash
+(= C</path/here>). While it may work, it is not guaranteed to do the right
+thing and is not a standard behaviour. You may opt to use uri_for() or
+uri_for_action() instead.
+
=cut
sub redirect {