Skip Menu |

This queue is for tickets about the version CPAN distribution.

Report information
The Basics
Id: 56993
Status: resolved
Priority: 0/
Queue: version
People
Owner: Nobody in particular
Requestors: TODDR [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: Important
Broken in: 0.82
Fixed in: (no value)

History Show all quoted text
  Tue Apr 27 19:16:07 2010 TODDR [...] cpan.org - Ticket created
Subject: version should install to site_lib for perl >= 5.12
As of 5.12, site_lib comes before the perl core libraries in @INC. All dual life modules should install to site_lib if installed from CPAN. Link to p5p thread on this topic. http://www.xray.mpe.mpg.de/mailing-lists/perl5-porters/2010-04/msg01353.html Patch attached for the fix. Thanks!
Subject: patch.txt
diff --git a/Makefile.PL b/Makefile.PL old mode 100644 new mode 100755 index f9b05be..6d9c942 --- a/Makefile.PL +++ b/Makefile.PL @@ -46,7 +46,7 @@ sub write_makefile AUTHOR => 'John Peacock <jpeacock@cpan.org>') : () ), - ( $] >= 5.009001 ? + ( $] >= 5.009001 && $] < 5.012000 ? ( INSTALLDIRS => 'perl' ) : () ),
  Wed Apr 28 00:07:26 2010 TODDR [...] cpan.org - Correspondence added
I missed the patch for Build.PL Here's both in one patch.
Subject: patch.txt
diff --git a/Build.PL b/Build.PL index 3983d62..1e413c0 100644 --- a/Build.PL +++ b/Build.PL @@ -40,7 +40,7 @@ my %build_arguments = ( dynamic_config => 1, dist_version_from => 'lib/version.pm', installdirs => - ($] > 5.009001) ? 'core' : 'site', + ($] > 5.009001 && $] < 5.012000) ? 'core' : 'site', ); mkdir($t->config_dir(),0777); diff --git a/Makefile.PL b/Makefile.PL index f9b05be..6d9c942 100644 --- a/Makefile.PL +++ b/Makefile.PL @@ -46,7 +46,7 @@ sub write_makefile AUTHOR => 'John Peacock <jpeacock@cpan.org>') : () ), - ( $] >= 5.009001 ? + ( $] >= 5.009001 && $] < 5.012000 ? ( INSTALLDIRS => 'perl' ) : () ),
  Wed Apr 28 00:07:34 2010 TODDR [...] cpan.org - Status changed from 'new' to 'open'
  Sun May 02 09:24:30 2010 john.peacock [...] havurah-software.org - Correspondence added
Subject: Re: [rt.cpan.org #56993] version should install to site_lib for perl >= 5.12
Date: Sun, 02 May 2010 09:24:00 -0400
To: bug-version [...] rt.cpan.org
From: John Peacock <john.peacock [...] havurah-software.org>
On 04/28/2010 12:07 AM, Todd Rinaldo via RT wrote: Show quoted text
> Queue: version > Ticket<URL: https://rt.cpan.org/Ticket/Display.html?id=56993> > > I missed the patch for Build.PL Here's both in one patch.
I think your patch is too restrictive. The @INC change was released as part of 5.11.0, so the limits should be >= 5.9.1 and < 5.11.0. That's what I am applying to my repo... John
  Sun May 02 10:21:28 2010 jpeacock [...] cpan.org - Correspondence added
Thanks! Applied (with tweaks)
  Sun May 02 10:21:32 2010 jpeacock [...] cpan.org - Status changed from 'open' to 'resolved'