Skip Menu |

This queue is for tickets about the AnyEvent-XMPP CPAN distribution.

Report information
The Basics
Id: 56969
Status: resolved
Priority: 0/
Queue: AnyEvent-XMPP
People
Owner: MSTPLBG [...] cpan.org
Requestors: andreas.marienborg [...] gmail.com
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: 0.51
Fixed in: (no value)

History Show all quoted text
  Tue Apr 27 08:38:07 2010 andreas.marienborg [...] gmail.com - Ticket created
Subject: create_cbs never called for MUC::Message
Hello :) I tried to use the method for extending Messages described in the POD, but it didn't work for MUC messages. I tracked it down to the overridden send_message in MUC::Message, where it passed undef, instead of $self->{create_cbs}. I patched it and pushed to github (http://github.com/omega/anyevent-xmpp). Please let me know if you want it some other way than a git clone Thanks for writing and maintaining this module!
  Mon Sep 13 02:51:06 2010 andreas.marienborg [...] gmail.com - Correspondence added
On Tue Apr 27 08:38:07 2010, ANDREMAR wrote: Show quoted text
> Hello :) > > I tried to use the method for extending Messages described in the POD, > but it didn't work for MUC messages. I tracked it down to the overridden > send_message in MUC::Message, where it passed undef, instead of > $self->{create_cbs}. > > I patched it and pushed to github (http://github.com/omega/anyevent-xmpp). > > Please let me know if you want it some other way than a git clone > > Thanks for writing and maintaining this module!
Sorry to go on about this, but did you perchance miss the initial mail? Is there anything I can do to get this into a released version?
  Mon Sep 13 04:51:10 2010 elmex [...] ta-sa.org - Correspondence added
Subject: Re: [rt.cpan.org #56969] create_cbs never called for MUC::Message
Date: Mon, 13 Sep 2010 10:50:56 +0200
To: Andreas Marienborg via RT <bug-AnyEvent-XMPP [...] rt.cpan.org>
From: Robin Redeker <elmex [...] ta-sa.org>
Hi! :) On Mon, Sep 13, 2010 at 02:51:07AM -0400, Andreas Marienborg via RT wrote: Show quoted text
> Queue: AnyEvent-XMPP > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=56969 > > > On Tue Apr 27 08:38:07 2010, ANDREMAR wrote:
> > Hello :) > > > > I tried to use the method for extending Messages described in the POD, > > but it didn't work for MUC messages. I tracked it down to the overridden > > send_message in MUC::Message, where it passed undef, instead of > > $self->{create_cbs}. > > > > I patched it and pushed to github (http://github.com/omega/anyevent-xmpp). > > > > Please let me know if you want it some other way than a git clone > > > > Thanks for writing and maintaining this module!
> > Sorry to go on about this, but did you perchance miss the initial mail?
I think I saw it, but it probably fell off the end of my todo list. Thanks for being persistent :-) Show quoted text
> Is there anything I can do to get this into a released version?
The problem is, that it is based on a version I don't really want to maintain anymore. The next version, which I should've released ages ago, but didn't due to other projects messing up my schedule, has a different API, which supports something like the create_cbs naturally. I hope I can release the new version soon. But the currently released one is more or less deprecated, unfortunately I know that there are users out there who will probably not like the new version (due to API breakage). I wish there was an easier way on CPAN to do these kind of releases. If there would be someone else who would really love to maintain the "old" version, I might be tempted to move on in a different namespace on CPAN. Greetings, Robin -- Robin Redeker | Deliantra, the free code+content MORPG elmex@ta-sa.org / r.redeker@gmail.com | http://www.deliantra.net http://www.ta-sa.org/ |
  Mon Sep 13 04:51:11 2010 The RT System itself - Status changed from 'new' to 'open'
  Mon Sep 13 04:54:01 2010 andreas.marienborg [...] gmail.com - Correspondence added
Subject: Re: [rt.cpan.org #56969] create_cbs never called for MUC::Message
Date: Mon, 13 Sep 2010 15:53:46 +0700
To: bug-AnyEvent-XMPP [...] rt.cpan.org
From: Andreas Marienborg <andreas.marienborg [...] gmail.com>
Thanks for the response :) Is the development of this new version on github or somewhere else where I can look at it already? :) No point in developing for a dying API etc :) And perhaps you should try to push a dev-release først (0.60_01 for instance), so people can check it out and migrate before pushing the new version? On Sep 13, 2010, at 3:51 PM, Robin Redeker via RT wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=56969 > > > Hi! :) > > On Mon, Sep 13, 2010 at 02:51:07AM -0400, Andreas Marienborg via RT wrote:
>> Queue: AnyEvent-XMPP >> Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=56969 > >> >> On Tue Apr 27 08:38:07 2010, ANDREMAR wrote:
>>> Hello :) >>> >>> I tried to use the method for extending Messages described in the POD, >>> but it didn't work for MUC messages. I tracked it down to the overridden >>> send_message in MUC::Message, where it passed undef, instead of >>> $self->{create_cbs}. >>> >>> I patched it and pushed to github (http://github.com/omega/anyevent-xmpp). >>> >>> Please let me know if you want it some other way than a git clone >>> >>> Thanks for writing and maintaining this module!
>> >> Sorry to go on about this, but did you perchance miss the initial mail?
> > I think I saw it, but it probably fell off the end of my todo list. > Thanks for being persistent :-) >
>> Is there anything I can do to get this into a released version?
> > The problem is, that it is based on a version I don't really want to maintain > anymore. > > The next version, which I should've released ages ago, but didn't due to other > projects messing up my schedule, has a different API, which supports something > like the create_cbs naturally. > > I hope I can release the new version soon. But the currently released one > is more or less deprecated, unfortunately I know that there are users > out there who will probably not like the new version (due to API breakage). > > I wish there was an easier way on CPAN to do these kind of releases. > If there would be someone else who would really love to maintain the "old" > version, I might be tempted to move on in a different namespace on CPAN. > > > Greetings, > Robin > > > -- > Robin Redeker | Deliantra, the free code+content MORPG > elmex@ta-sa.org / r.redeker@gmail.com | http://www.deliantra.net > http://www.ta-sa.org/ | >
  Mon Sep 13 05:07:39 2010 elmex [...] ta-sa.org - Correspondence added
Subject: Re: [rt.cpan.org #56969] create_cbs never called for MUC::Message
Date: Mon, 13 Sep 2010 11:07:25 +0200
To: Andreas Marienborg via RT <bug-AnyEvent-XMPP [...] rt.cpan.org>
From: Robin Redeker <elmex [...] ta-sa.org>
Hi! On Mon, Sep 13, 2010 at 04:54:01AM -0400, Andreas Marienborg via RT wrote: Show quoted text
> Queue: AnyEvent-XMPP > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=56969 > > > Thanks for the response :) > > Is the development of this new version on github or somewhere else where I can look at it already? :)
Sure, see the connection_ref branch in the main git repository: http://git.ta-sa.org/git/AnyEvent-XMPP/log/?h=connection_ref Show quoted text
> No point in developing for a dying API etc :) > > And perhaps you should try to push a dev-release først (0.60_01 for instance), so people can check it out and migrate before pushing the new version?
Ah yes, those things. I wondered how it works. Just appending _01 to the version? I think I will try to find some time for some release like that this week. Greetings, Robin -- Robin Redeker | Deliantra, the free code+content MORPG elmex@ta-sa.org / r.redeker@gmail.com | http://www.deliantra.net http://www.ta-sa.org/ |
  Wed Oct 10 06:18:46 2012 MSTPLBG [...] cpan.org - Taken
  Wed Oct 10 06:19:09 2012 MSTPLBG [...] cpan.org - Correspondence added
I have pushed a fix for this which will be included in the next release: https://github.com/AnyEvent-XMPP/AnyEvent- XMPP/commit/2bfc7392a217087e10bb037b440b9df727aa92f8
  Wed Oct 10 06:21:50 2012 MSTPLBG [...] cpan.org - Correspondence added
On Wed Oct 10 06:19:09 2012, MSTPLBG wrote: Show quoted text
> I have pushed a fix for this which will be included in the next
release: Show quoted text
> > https://github.com/AnyEvent-XMPP/AnyEvent- > XMPP/commit/2bfc7392a217087e10bb037b440b9df727aa92f8
Sorry, my mistake. I meant: I pushed your fix and it’ll be included in the next release. Thanks! https://github.com/AnyEvent-XMPP/AnyEvent- XMPP/commit/6939fe24663745e1c5c16945d7ab518a211c7faa
  Wed Oct 10 07:13:41 2012 MSTPLBG [...] cpan.org - Correspondence added
This is fixed with AnyEvent::XMPP 0.53
  Wed Oct 10 07:13:42 2012 MSTPLBG [...] cpan.org - Status changed from 'open' to 'resolved'