Skip Menu |

This queue is for tickets about the Archive-Extract CPAN distribution.

Report information
The Basics
Id: 56927
Status: resolved
Worked: 30 min
Priority: 0/
Queue: Archive-Extract

People
Owner: BINGOS [...] cpan.org
Requestors: Robin Barker (no email address)
Cc:
AdminCc:

Bug Information
Severity: Unimportant
Broken in: 0.38
Fixed in: (no value)



Subject: [PATCH] Unnecessary chdir/INC manipulation in test
The start of 01_Archive-Extract.t has some BEGIN{} code for PERL_CORE. There is an attempt to chdir to a directory that does not exist and a setting of @INC that is redundant (and caused the test to fail when I had an old Config.pm file in the parent directory of the perl source). The core perl test architecture already chdirs to the correct source directory and makes the appropriate @INC settings, so there is nothing that needs to be done. (Sorry, the attached patch is relative to perl source not CPAN.)
Subject: 0001-remove-unused-unnecessary-chdir-INC-manipulation.patch
From b1604dec76513e6e51e4ca1376de747c3c12dfb6 Mon Sep 17 00:00:00 2001 From: Robin Barker <rmbarker@cpan.org> Date: Sun, 25 Apr 2010 15:26:02 +0100 Subject: [PATCH] remove unused/unnecessary chdir/INC manipulation --- cpan/Archive-Extract/t/01_Archive-Extract.t | 7 ------- 1 files changed, 0 insertions(+), 7 deletions(-) diff --git a/cpan/Archive-Extract/t/01_Archive-Extract.t b/cpan/Archive-Extract/t/01_Archive-Extract.t index 93c9026..6394533 100644 --- a/cpan/Archive-Extract/t/01_Archive-Extract.t +++ b/cpan/Archive-Extract/t/01_Archive-Extract.t @@ -1,10 +1,3 @@ -BEGIN { - if( $ENV{PERL_CORE} ) { - chdir '../lib/Archive/Extract' if -d '../lib/Archive/Extract'; - unshift @INC, '../../..', '../../../..'; - } -} - BEGIN { chdir 't' if -d 't' }; BEGIN { mkdir 'out' unless -d 'out' }; -- 1.6.3.3
Hi, Thanks for this. I've applied and committed to svn repo. It will be released with the next CPAN version which will be 0.42 and updated in blead later this evening. Cheers.