Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the POE-Filter-DHCPd-Lease CPAN distribution.

Report information
The Basics
Id: 56773
Status: resolved
Priority: 0/
Queue: POE-Filter-DHCPd-Lease
People
Owner: JHTHORSEN [...] cpan.org
Requestors: littlesavage [...] orionet.ru
Cc:
AdminCc:
Bug Information
Severity: Normal
Broken in: 0.04
Fixed in: (no value)

History Show all quoted text
  Wed Apr 21 04:09:00 2010 littlesavage [...] orionet.ru - Ticket created
Subject: POE-Filter-DHCPd-Lease 0.4 does not build
POE-Filter-DHCPd-Lease does not passes tests: 1. Test::Pod and Test::Pod::Coverage does not exists in Makefile.PL. 2. 10-filter.t does not passes 'ends' test on systems with non-UTC locales. Attached patch fix this probles.
Subject: POE-Filter-DHCPd-Lease.patch
diff -ru POE-Filter-DHCPd-Lease-0.04/META.yml POE-Filter-DHCPd-Lease-0.04_new/META.yml --- POE-Filter-DHCPd-Lease-0.04/META.yml 2009-07-21 17:18:12.000000000 +0400 +++ POE-Filter-DHCPd-Lease-0.04_new/META.yml 2010-04-21 11:52:29.593789588 +0400 @@ -3,9 +3,14 @@ author: - 'Jan Henning Thorsen, C<< <jhthorsen-at-cpan-org> >>' build_requires: + ExtUtils::MakeMaker: 6.42 Test::More: 0 + Test::Pod: 0 + Test::Pod::Coverage: 0 +configure_requires: + ExtUtils::MakeMaker: 6.42 distribution_type: module -generated_by: 'Module::Install version 0.77' +generated_by: 'Module::Install version 0.92' license: perl meta-spec: url: http://module-build.sourceforge.net/META-spec-v1.4.html @@ -16,7 +21,6 @@ - inc - t requires: - DateTime: 0 POE::Filter: 0 resources: license: http://dev.perl.org/licenses/ diff -ru POE-Filter-DHCPd-Lease-0.04/Makefile.PL POE-Filter-DHCPd-Lease-0.04_new/Makefile.PL --- POE-Filter-DHCPd-Lease-0.04/Makefile.PL 2009-07-21 16:29:46.000000000 +0400 +++ POE-Filter-DHCPd-Lease-0.04_new/Makefile.PL 2010-04-21 11:53:52.806800739 +0400 @@ -4,8 +4,9 @@ all_from q(lib/POE/Filter/DHCPd/Lease.pm); requires q(POE::Filter) => 0; -requires q(DateTime) => 0; test_requires q(Test::More) => 0; +test_requires q(Test::Pod) => 0; +test_requires q(Test::Pod::Coverage) => 0; auto_install; WriteAll; diff -ru POE-Filter-DHCPd-Lease-0.04/t/10-filter.t POE-Filter-DHCPd-Lease-0.04_new/t/10-filter.t --- POE-Filter-DHCPd-Lease-0.04/t/10-filter.t 2009-07-21 17:10:09.000000000 +0400 +++ POE-Filter-DHCPd-Lease-0.04_new/t/10-filter.t 2010-04-21 11:34:01.938648083 +0400 @@ -3,6 +3,7 @@ use strict; use warnings; use lib './lib'; +use Time::Local; use POE::Filter::DHCPd::Lease; use Test::More tests => 16; @@ -12,7 +13,7 @@ for my $bufsize (16, 2048) { my $ctrl = 100; - my @ends = (1216057352, 1218858291); + my @ends = (timelocal(32,42,19,14,7-1,2008), timelocal(51,44,5,16,8-1,2008)); my @macs = qw/001133556611 aaff33552211/; seek DATA, $datapos, 0;
  Wed Apr 21 04:58:56 2010 JHTHORSEN [...] cpan.org - Correspondence added
On Wed Apr 21 04:09:00 2010, littlesavage wrote: Show quoted text
> POE-Filter-DHCPd-Lease does not passes tests: > > 1. Test::Pod and Test::Pod::Coverage does not exists in Makefile.PL. > 2. 10-filter.t does not passes 'ends' test on systems with non-UTC
locales. Show quoted text
> > Attached patch fix this probles.
I've just uploaded a new version which I hope will work better for you. Let me know so I can close the ticket.
  Wed Apr 21 04:58:58 2010 The RT System itself - Status changed from 'new' to 'open'
  Wed Apr 21 04:59:11 2010 JHTHORSEN [...] cpan.org - Taken
  Wed Apr 21 07:03:03 2010 littlesavage [...] orionet.ru - Correspondence added
From: littlesavage [...] orionet.ru
Show quoted text
> I've just uploaded a new version which I hope will work better for you. > Let me know so I can close the ticket.
With new version there is no problem with Test::Pod and Test::Pod::Coverage anymore. But tests with end of lease time still failed. I'm attached my log. There is end time of '2008/07/14 19:42:32' in test file. I have UTC+4 local timezone. timelocal() converts '2008/07/14 19:42:32' to 1216064552 epoch.
Subject: log.txt
$ make test PERL_DL_NONLAZY=1 /usr/local/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'inc', 'blib/lib', 'blib/arch')" t/00-load.t t/10-filter.t t/99-pod-coverage.t t/99-pod.t t/00-load............ok t/10-filter..........# reading with bufsize 16 t/10-filter..........NOK 3/16 # Failed test 'ends 1216057352' # at t/10-filter.t line 42. # got: '1216050152' # expected: '1216057352' t/10-filter..........NOK 6/16 # Failed test 'ends 1218858291' # at t/10-filter.t line 42. # got: '1218851091' # expected: '1218858291' # reading with bufsize 2048 t/10-filter..........NOK 11/16 # Failed test 'ends 1216057352' # at t/10-filter.t line 42. # got: '1216050152' # expected: '1216057352' t/10-filter..........NOK 14/16 # Failed test 'ends 1218858291' # at t/10-filter.t line 42. # got: '1218851091' # expected: '1218858291' # Looks like you failed 4 tests of 16. t/10-filter..........dubious Test returned status 4 (wstat 1024, 0x400) DIED. FAILED tests 3, 6, 11, 14 Failed 4/16 tests, 75.00% okay t/99-pod-coverage....skipped all skipped: Test::Pod::Coverage required t/99-pod.............skipped all skipped: Test::Pod required Failed Test Stat Wstat Total Fail List of Failed ------------------------------------------------------------------------------- t/10-filter.t 4 1024 16 4 3 6 11 14 2 tests skipped. Failed 1/4 test scripts. 4/17 subtests failed. Files=4, Tests=17, 1 wallclock secs ( 0.23 cusr + 0.07 csys = 0.30 CPU) Failed 1/4 test programs. 4/17 subtests failed. *** Error code 255
  Wed Apr 21 07:27:56 2010 JHTHORSEN [...] cpan.org - Correspondence added
Subject: Re: [rt.cpan.org #56773] POE-Filter-DHCPd-Lease 0.4 does not build
Date: Wed, 21 Apr 2010 13:27:14 +0200
To: bug-POE-Filter-DHCPd-Lease [...] rt.cpan.org
From: Jan Henning Thorsen <jhthorsen [...] cpan.org>
Could you try this test before I release it? http://github.com/jhthorsen/poe-filter-dhcpd-lease/blob/master/t/10-filter.t http://github.com/jhthorsen/poe-filter-dhcpd-lease/raw/master/t/10-filter.t On Wed, Apr 21, 2010 at 1:03 PM, Alexey Illarionov via RT <bug-POE-Filter-DHCPd-Lease@rt.cpan.org> wrote: Show quoted text
>       Queue: POE-Filter-DHCPd-Lease >  Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=56773 > >
>> I've just uploaded a new version which I hope will work better for you. >> Let me know so I can close the ticket.
> > With new version there is no problem with Test::Pod and > Test::Pod::Coverage anymore. > > But tests with end of lease time still failed. > > I'm attached my log. > > There is end time of '2008/07/14 19:42:32' in test file. > I have UTC+4 local timezone. > timelocal() converts '2008/07/14 19:42:32' to 1216064552 epoch. > > > > $ make test > PERL_DL_NONLAZY=1 /usr/local/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'inc', 'blib/lib', 'blib/arch')" t/00-load.t t/10-filter.t t/99-pod-coverage.t t/99-pod.t > t/00-load............ok > t/10-filter..........# reading with bufsize 16 > t/10-filter..........NOK 3/16 > #   Failed test 'ends 1216057352' > #   at t/10-filter.t line 42. > #          got: '1216050152' > #     expected: '1216057352' > t/10-filter..........NOK 6/16 > #   Failed test 'ends 1218858291' > #   at t/10-filter.t line 42. > #          got: '1218851091' > #     expected: '1218858291' > # reading with bufsize 2048 > t/10-filter..........NOK 11/16 > #   Failed test 'ends 1216057352' > #   at t/10-filter.t line 42. > #          got: '1216050152' > #     expected: '1216057352' > t/10-filter..........NOK 14/16 > #   Failed test 'ends 1218858291' > #   at t/10-filter.t line 42. > #          got: '1218851091' > #     expected: '1218858291' > # Looks like you failed 4 tests of 16. > t/10-filter..........dubious >        Test returned status 4 (wstat 1024, 0x400) > DIED. FAILED tests 3, 6, 11, 14 >        Failed 4/16 tests, 75.00% okay > t/99-pod-coverage....skipped >        all skipped: Test::Pod::Coverage required > t/99-pod.............skipped >        all skipped: Test::Pod required > Failed Test   Stat Wstat Total Fail  List of Failed > ------------------------------------------------------------------------------- > t/10-filter.t    4  1024    16    4  3 6 11 14 > 2 tests skipped. > Failed 1/4 test scripts. 4/17 subtests failed. > Files=4, Tests=17,  1 wallclock secs ( 0.23 cusr +  0.07 csys =  0.30 CPU) > Failed 1/4 test programs. 4/17 subtests failed. > *** Error code 255 > > >
  Sat Apr 24 04:00:57 2010 littlesavage [...] orionet.ru - Correspondence added
From: littlesavage [...] orionet.ru
Срд Апр 21 07:27:56 2010, JHTHORSEN писал: Show quoted text
> Could you try this test before I release it? > http://github.com/jhthorsen/poe-filter-dhcpd-lease/blob/master/t/10- > filter.t > http://github.com/jhthorsen/poe-filter-dhcpd-lease/raw/master/t/10- > filter.t
This test works fine. It can be relased and this bug may be closed. Thanks a lot!
  Sat Apr 24 10:36:09 2010 JHTHORSEN [...] cpan.org - Correspondence added
Subject: Re: [rt.cpan.org #56773] POE-Filter-DHCPd-Lease 0.4 does not build
Date: Sat, 24 Apr 2010 16:35:35 +0200
To: bug-POE-Filter-DHCPd-Lease [...] rt.cpan.org
From: Jan Henning Thorsen <jhthorsen [...] cpan.org>
Thank you as well. I just uploaded 0.05_01 to CPAN. Should be available in a couple of hours i guess... On Sat, Apr 24, 2010 at 10:00 AM, Alexey Illarionov via RT <bug-POE-Filter-DHCPd-Lease@rt.cpan.org> wrote: Show quoted text
>       Queue: POE-Filter-DHCPd-Lease >  Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=56773 > > > Срд Апр 21 07:27:56 2010, JHTHORSEN писал:
>> Could you try this test before I release it? >> http://github.com/jhthorsen/poe-filter-dhcpd-lease/blob/master/t/10- >> filter.t >> http://github.com/jhthorsen/poe-filter-dhcpd-lease/raw/master/t/10- >> filter.t
> > This test works fine. > > It can be relased and this bug may be closed. Thanks a lot! >
  Sat Apr 24 10:37:50 2010 JHTHORSEN [...] cpan.org - Correspondence added
Uploaded a new dist: 0.05_01 with fix that takes care of different timezones.
  Sat Apr 24 10:37:53 2010 JHTHORSEN [...] cpan.org - Status changed from 'open' to 'resolved'