Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Pod-Simple CPAN distribution.

Report information
The Basics
Id: 56725
Status: resolved
Priority: 0/
Queue: Pod-Simple
People
Owner: Nobody in particular
Requestors: user42 [...] zip.com.au
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 3.15

History Show all quoted text
  Mon Apr 19 15:06:51 2010 user42 [...] zip.com.au - Ticket created
Subject: HTMLBatch blkbluw_.css vs _blkbluw.css
Date: Tue, 20 Apr 2010 05:06:25 +1000
To: bug-Pod-Simple [...] rt.cpan.org
From: Kevin Ryde <user42 [...] zip.com.au>
Pod::Simple::HTMLBatch 3.13 generates a stylesheet line <link rel="alternate stylesheet" title="blkbluw " type="text/css" href="blkbluw_.css" media="all" > apparently using file "blkbluw_.css", but the file it creates in the output directory is called "_blkbluw.css". I wonder if one of them has the _ at the wrong end. -- For lucky best wash use Mr Sparkle.
  Mon Apr 19 16:49:26 2010 david [...] kineticode.com - Correspondence added
Subject: Re: [rt.cpan.org #56725] HTMLBatch blkbluw_.css vs _blkbluw.css
Date: Mon, 19 Apr 2010 13:49:12 -0700
To: bug-Pod-Simple [...] rt.cpan.org
From: "David E. Wheeler" <david [...] kineticode.com>
On Apr 19, 2010, at 12:06 PM, Kevin Ryde via RT wrote: Show quoted text
> Pod::Simple::HTMLBatch 3.13 generates a stylesheet line > > <link rel="alternate stylesheet" title="blkbluw " type="text/css" href="blkbluw_.css" media="all" > > > apparently using file "blkbluw_.css", but the file it creates in the > output directory is called "_blkbluw.css". I wonder if one of them has > the _ at the wrong end.
Hrm. Looks like I changed it from _blkbluw.css to blkbluw_.css in http://github.com/theory/pod-simple/commit/ebf9054d9dd4411412ba4da8ce559e06afad93e0. I don't recall why. Does this patch fix it? --- a/lib/Pod/Simple/HTMLBatch.pm +++ b/lib/Pod/Simple/HTMLBatch.pm @@ -726,7 +726,7 @@ sub _gen_css_wad { 'whtgrng', # white_with_green_on_grey 'grygrnw', # grey_with_green_on_white ) { - my $outname = "$variation\_"; + my $outname = $variation; my $this_css = join "\n", "/* This file is autogenerated. Do not edit. $outname */\n", "\@import url(\"./_$variation.css\");", @@ -735,7 +735,7 @@ sub _gen_css_wad { ; my $name = $outname; $name =~ tr/-_/ /; - $self->add_css( "$outname.css", 0, $name, 0, 0, \$this_css); + $self->add_css( "_$outname.css", 0, $name, 0, 0, \$this_css); } return; Best, David
  Mon Apr 19 16:49:29 2010 The RT System itself - Status changed from 'new' to 'open'
  Tue Apr 27 13:49:13 2010 dwheeler [...] cpan.org - Correspondence added
Hey Kevin, had a chance to try this patch yet? Thanks, David On Mon Apr 19 16:49:26 2010, david@kineticode.com wrote: Show quoted text
> On Apr 19, 2010, at 12:06 PM, Kevin Ryde via RT wrote: >
> > Pod::Simple::HTMLBatch 3.13 generates a stylesheet line > > > > <link rel="alternate stylesheet" title="blkbluw " type="text/css"
> href="blkbluw_.css" media="all" >
> > > > apparently using file "blkbluw_.css", but the file it creates in the > > output directory is called "_blkbluw.css". I wonder if one of them
> has
> > the _ at the wrong end.
> > Hrm. Looks like I changed it from _blkbluw.css to blkbluw_.css in > http://github.com/theory/pod- > simple/commit/ebf9054d9dd4411412ba4da8ce559e06afad93e0. I don't recall > why. Does this patch fix it? > > --- a/lib/Pod/Simple/HTMLBatch.pm > +++ b/lib/Pod/Simple/HTMLBatch.pm > @@ -726,7 +726,7 @@ sub _gen_css_wad { > 'whtgrng', # white_with_green_on_grey > 'grygrnw', # grey_with_green_on_white > ) { > - my $outname = "$variation\_"; > + my $outname = $variation; > my $this_css = join "\n", > "/* This file is autogenerated. Do not edit. $outname */\n", > "\@import url(\"./_$variation.css\");", > @@ -735,7 +735,7 @@ sub _gen_css_wad { > ; > my $name = $outname; > $name =~ tr/-_/ /; > - $self->add_css( "$outname.css", 0, $name, 0, 0, \$this_css); > + $self->add_css( "_$outname.css", 0, $name, 0, 0, \$this_css); > } > > return; > > > Best, > > David >
  Tue Apr 27 13:49:16 2010 dwheeler [...] cpan.org - Status changed from 'open' to 'stalled'
  Wed Apr 28 20:15:21 2010 user42 [...] zip.com.au - Correspondence added
Subject: Re: [rt.cpan.org #56725] HTMLBatch blkbluw_.css vs _blkbluw.css
Date: Thu, 29 Apr 2010 10:14:21 +1000
To: bug-Pod-Simple [...] rt.cpan.org
From: Kevin Ryde <user42 [...] zip.com.au>
"David Wheeler via RT" <bug-Pod-Simple@rt.cpan.org> writes: Show quoted text
> > Hey Kevin, had a chance to try this patch yet?
Oh, yes, it seems pretty right.
  Wed Apr 28 20:15:21 2010 The RT System itself - Status changed from 'stalled' to 'open'
  Thu Apr 29 12:48:35 2010 david [...] kineticode.com - Correspondence added
Subject: Re: [rt.cpan.org #56725] HTMLBatch blkbluw_.css vs _blkbluw.css
Date: Thu, 29 Apr 2010 09:48:22 -0700
To: bug-Pod-Simple [...] rt.cpan.org
From: "David E. Wheeler" <david [...] kineticode.com>
On Apr 28, 2010, at 5:15 PM, Kevin Ryde via RT wrote: Show quoted text
> Oh, yes, it seems pretty right.
Great, thanks. Committed in http://github.com/theory/pod-simple/commit/4ccf67a46477ab5c54ce67d5db28d5ddbf4d11b9. Best, David
  Fri May 21 20:01:19 2010 dwheeler [...] cpan.org - Status changed from 'open' to 'patched'
  Fri Nov 12 15:09:01 2010 dwheeler [...] cpan.org - Status changed from 'patched' to 'resolved'
  Fri Nov 12 15:09:02 2010 dwheeler [...] cpan.org - Fixed in 3.15 added