| Subject: | Unnecessary 5.10 requirement |
In lib/Dancer/Plugin/SiteMap.pm, the line 'use 5.0100;' preventing installation of this module on any version less than 5.10, but it there doesn't seem to be any code that requires that restriction. After removing that line, here are the results (this is perl 5.8.9 on freebsd-i386):
Show quoted text
Show quoted text
Skip blib/lib/Dancer/Plugin/logs/development.log (unchanged)
Manifying blib/man3/Dancer::Plugin::SiteMap.3
Show quoted text
and installing the module and using it in an existing Dancer app (created using dancer -a), the /sitemap and /sitemap.xml links work as expected.
Obviously it is your prerogative to limit your module's use to Perl versions 5.10 and later, but why not enable 5.8 users (at least) to use your module too, especially considering that Dancer's Perl version requirements are much lower.
Show quoted text
# perl Makefile.PL
Writing Makefile for Dancer::Plugin::SiteMapShow quoted text
# make
Skip blib/lib/Dancer/Plugin/SiteMap.pm (unchanged)Skip blib/lib/Dancer/Plugin/logs/development.log (unchanged)
Manifying blib/man3/Dancer::Plugin::SiteMap.3
Show quoted text
# make test
# perl -c blib/lib/Dancer/Plugin/SiteMap.pm
blib/lib/Dancer/Plugin/SiteMap.pm syntax OK# perl -c blib/lib/Dancer/Plugin/SiteMap.pm
and installing the module and using it in an existing Dancer app (created using dancer -a), the /sitemap and /sitemap.xml links work as expected.
Obviously it is your prerogative to limit your module's use to Perl versions 5.10 and later, but why not enable 5.8 users (at least) to use your module too, especially considering that Dancer's Perl version requirements are much lower.