Skip Menu |

This queue is for tickets about the DBIx-Class CPAN distribution.

Report information
The Basics
Id: 56698
Status: resolved
Priority: 0/
Queue: DBIx-Class
People
Owner: Nobody in particular
Requestors: avar [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: Important
Broken in: 0.08121
Fixed in: 0.08122

History Show all quoted text
  Sun Apr 18 15:06:31 2010 avar [...] cpan.org - Ticket created
Subject: t/06notabs.t fails: "Can't stat maint: No such file or directory"
t/06notabs.t ..................................... Can't stat maint: No such file or directory at /usr/local/share/perl/5.10.1/Test/NoTabs.pm line 61 t/06notabs.t ..................................... 1/? # Failed test 'No tabs in 't/93single_accessor_object.t' on line 48' # at /usr/local/share/perl/5.10.1/Test/NoTabs.pm line 89. # Looks like you failed 1 test of 474.
  Sun Apr 18 17:08:25 2010 ribasushi [...] leporine.io - Correspondence added
On Sun Apr 18 15:06:31 2010, AVAR wrote: Show quoted text
> t/06notabs.t ..................................... Can't stat maint: No > such file or directory > at /usr/local/share/perl/5.10.1/Test/NoTabs.pm line 61 > t/06notabs.t ..................................... 1/? > # Failed test 'No tabs in 't/93single_accessor_object.t' on line 48' > # at /usr/local/share/perl/5.10.1/Test/NoTabs.pm line 89. > # Looks like you failed 1 test of 474.
Weird... this somehow got stuck in the repo (but was fine in the checkout). Fixed: http://dev.catalystframework.org/svnweb/bast/revision?rev=9187
  Sun Apr 18 17:08:29 2010 The RT System itself - Status changed from 'new' to 'open'
  Sun Apr 18 17:08:33 2010 ribasushi [...] leporine.io - Status changed from 'open' to 'patched'
  Sun Apr 18 17:20:43 2010 avar [...] cpan.org - Correspondence added
On Sun Apr 18 17:08:25 2010, RIBASUSHI wrote: Show quoted text
> On Sun Apr 18 15:06:31 2010, AVAR wrote:
> > t/06notabs.t ..................................... Can't stat maint:
No Show quoted text
> > such file or directory > > at /usr/local/share/perl/5.10.1/Test/NoTabs.pm line 61 > > t/06notabs.t ..................................... 1/? > > # Failed test 'No tabs in 't/93single_accessor_object.t' on line
48' Show quoted text
> > # at /usr/local/share/perl/5.10.1/Test/NoTabs.pm line 89. > > # Looks like you failed 1 test of 474.
> > Weird... this somehow got stuck in the repo (but was fine in the > checkout). Fixed: > http://dev.catalystframework.org/svnweb/bast/revision?rev=9187
Nice. As an aside I'd like to suggest that these sorts of tests be put in xt/ or run only when AUTHOR_TESTS is true. It's silly that end-users potentially fail installations because someone didn't use the right coding style somewhere in dbic.
  Sun Apr 18 17:20:48 2010 The RT System itself - Status changed from 'patched' to 'open'
  Thu Jun 03 06:34:25 2010 ribasushi [...] leporine.io - Correspondence added
On Sun Apr 18 17:20:43 2010, AVAR wrote: Show quoted text
> On Sun Apr 18 17:08:25 2010, RIBASUSHI wrote:
> > On Sun Apr 18 15:06:31 2010, AVAR wrote:
> > > t/06notabs.t ..................................... Can't stat maint:
> No
> > > such file or directory > > > at /usr/local/share/perl/5.10.1/Test/NoTabs.pm line 61 > > > t/06notabs.t ..................................... 1/? > > > # Failed test 'No tabs in 't/93single_accessor_object.t' on line
> 48'
> > > # at /usr/local/share/perl/5.10.1/Test/NoTabs.pm line 89. > > > # Looks like you failed 1 test of 474.
> > > > Weird... this somehow got stuck in the repo (but was fine in the > > checkout). Fixed: > > http://dev.catalystframework.org/svnweb/bast/revision?rev=9187
> > Nice. > > As an aside I'd like to suggest that these sorts of tests be put in xt/ > or run only when AUTHOR_TESTS is true. It's silly that end-users > potentially fail installations because someone didn't use the right > coding style somewhere in dbic.
There was boilerplate at the top of the script to skip unless vars are set. I imagine you had something in there. Anyway - it's in xt/ now http://dev.catalystframework.org/svnweb/bast/revision?rev=9574
  Thu Jun 03 06:34:26 2010 ribasushi [...] leporine.io - Status changed from 'open' to 'patched'
  Fri Jun 04 07:13:10 2010 ribasushi [...] leporine.io - Status changed from 'patched' to 'resolved'
  Fri Jun 04 07:13:11 2010 ribasushi [...] leporine.io - Fixed in 0.08122 added
  Fri Jun 04 08:23:44 2010 avar [...] cpan.org - Correspondence added
On Thu Jun 03 06:34:25 2010, RIBASUSHI wrote: Show quoted text
> On Sun Apr 18 17:20:43 2010, AVAR wrote:
> > As an aside I'd like to suggest that these sorts of tests be put in
xt/ Show quoted text
> > or run only when AUTHOR_TESTS is true. It's silly that end-users > > potentially fail installations because someone didn't use the right > > coding style somewhere in dbic.
> > There was boilerplate at the top of the script to skip unless vars are > set. I imagine you had something in there. Anyway - it's in xt/ now > http://dev.catalystframework.org/svnweb/bast/revision?rev=9574
Thanks. Looking at the files they check for AUTOMATED_TESTING=1. I'm pretty sure that cpan clients set that automatically when installing. I certainly don't have any cpan-related vars that I've set manually in my environment. It just failed when I installed it from the CPAN. Anyway, good to see that it's fixed. Thanks.
  Fri Jun 04 08:23:45 2010 The RT System itself - Status changed from 'resolved' to 'open'
  Fri Jun 04 08:55:25 2010 ribasushi [...] leporine.io - Status changed from 'open' to 'resolved'